Skip to content

MNT: reduce scope of test_get_package_metadata_returns_expected_results to mock_package #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shourya1419-netizen wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −18
Open

MNT: reduce scope of test_get_package_metadata_returns_expected_results to mock_package #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60f12a5
MNT: reduce scope of test_get_package_metadata_returns_expected_resul…
shourya1419-netizen Mar 5, 2026
4647c9e
Merge branch 'main' into fix-package-metadata-test
fkiraly Apr 19, 2026
0c8d3ab
[AUTOMATED] update CONTRIBUTORS.md
github-actions[bot] Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
[![All Contributors](https://img.shields.io/badge/all_contributors-14-orange.svg?style=flat-square)](#contributors)
[![All Contributors](https://img.shields.io/badge/all_contributors-15-orange.svg?style=flat-square)](#contributors)
<!-- ALL-CONTRIBUTORS-BADGE:END -->

This project follows the
Expand Down Expand Up @@ -32,6 +32,7 @@ Thanks goes to these wonderful people
</tr>
<tr>
<td align="center" valign="top" width="11.11%"><a href="https://github.com/achieveordie"><img src="https://avatars.githubusercontent.com/u/54197164?v=4" width="100px;" alt=""/><br /><sub><b>Sagar Mishra</b></sub></a></td>
<td align="center" valign="top" width="11.11%"><a href="https://github.com/sid200727"><img src="https://avatars.githubusercontent.com/u/sid200727?v=4" width="100px;" alt=""/><br /><sub><b>Siddhi Khandelwal</b></sub></a></td>
<td align="center" valign="top" width="11.11%"><a href="https://github.com/SimonBlanke"><img src="https://avatars.githubusercontent.com/u/20640612?v=4" width="100px;" alt=""/><br /><sub><b>Simon Blanke</b></sub></a></td>
<td align="center" valign="top" width="11.11%"><a href="https://github.com/tpvasconcelos"><img src="https://avatars.githubusercontent.com/u/17701527?v=4" width="100px;" alt=""/><br /><sub><b>Tomas P. de Vasconcelos</b></sub></a></td>
<td align="center" valign="top" width="11.11%"><a href="https://github.com/szepeviktor"><img src="https://avatars.githubusercontent.com/u/952007?v=4" width="100px;" alt=""/><br /><sub><b>Viktor Szépe</b></sub></a></td>
Expand Down
Empty file added pre-commit
View file
Open in desktop
Empty file.
26 changes: 9 additions & 17 deletions skbase/lookup/tests/test_lookup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,8 @@
SKBASE_BASE_CLASSES,
SKBASE_CLASSES_BY_MODULE,
SKBASE_FUNCTIONS_BY_MODULE,
SKBASE_MODULES,
SKBASE_PUBLIC_CLASSES_BY_MODULE,
SKBASE_PUBLIC_FUNCTIONS_BY_MODULE,
SKBASE_PUBLIC_MODULES,
ClassWithABTrue,
Parent,
)
Expand Down Expand Up @@ -722,30 +720,24 @@ def test_get_package_metadata_returns_expected_results(
):
"""Test that get_package_metadata_returns expected results using skbase."""
results = get_package_metadata(
"skbase",
"skbase.lookup.tests.mock_package",
exclude_non_public_items=exclude_non_public_items,
exclude_non_public_modules=exclude_non_public_modules,
package_base_classes=SKBASE_BASE_CLASSES,
modules_to_ignore="tests",
classes_to_exclude=TagAliaserMixin,
suppress_import_stdout=False,
)
public_modules_excluding_tests = [
module
for module in SKBASE_PUBLIC_MODULES
if not _is_ignored_module(module, modules_to_ignore="tests")
]
modules_excluding_tests = [
module
for module in SKBASE_MODULES
if not _is_ignored_module(module, modules_to_ignore="tests")
]
if exclude_non_public_modules:
assert tuple(results.keys()) == tuple(public_modules_excluding_tests)
else:
assert tuple(results.keys()) == tuple(modules_excluding_tests)
modules_excluding_tests = list(results.keys())
public_modules_excluding_tests = modules_excluding_tests

for module in results:

if exclude_non_public_modules:
assert tuple(results.keys()) == tuple(public_modules_excluding_tests)
else:
assert tuple(results.keys()) == tuple(modules_excluding_tests)

if exclude_non_public_items:
module_funcs = SKBASE_PUBLIC_FUNCTIONS_BY_MODULE.get(module, ())
module_classes = SKBASE_PUBLIC_CLASSES_BY_MODULE.get(module, ())
Expand Down