Skip to content

[ENH] Add regression test ensuring filter_tags in all_objects does not return empty results #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shourya1419-netizen wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[ENH] Add regression test ensuring filter_tags in all_objects does not return empty results #512

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7814248
Add regression test ensuring filter_tags does not return empty results
shourya1419-netizen Mar 4, 2026
2bb4b1b
Merge branch 'main' into test-filter-tags-regression
shourya1419-netizen Mar 5, 2026
25d5fc8
fix:runtime code generation
shourya1419-netizen Mar 5, 2026
b142b71
Merge branch 'test-filter-tags-regression' of https://github.com/shou…
shourya1419-netizen Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions skbase/tests/test_lookup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,26 @@ def test_all_objects_returns_class_name_for_alias(tmp_path, monkeypatch):

sys.modules.pop(f"{pkg_name}.module", None)
sys.modules.pop(pkg_name, None)


def test_all_objects_filter_tags_not_empty(tmp_path, monkeypatch):
from skbase.lookup import all_objects

root = tmp_path / "pkg"
root.mkdir()

(root / "__init__.py").write_text(
"from .module import MyObject\n__all__ = ['MyObject']\n"
)

(root / "module.py").write_text(
"from skbase.base import BaseObject\n"
"class MyObject(BaseObject):\n"
" _tags = {'my_tag': True}\n"
)

monkeypatch.syspath_prepend(str(tmp_path))

objs = all_objects(package_name="pkg", filter_tags="my_tag")

assert len(objs) > 0