[ENH] isolate lookup tests to dedicated mock package

.all-contributorsrc

@@ -161,6 +161,16 @@
         "code",
         "test"
       ]
+    },
+    {
+      "login": "arnavk23",
+      "name": "Arnav Kapoor",
+      "avatar_url": "https://avatars.githubusercontent.com/u/arnavk23?v=4",
+      "profile": "https://github.com/arnavk23",
+      "contributions": [
+        "code",
+        "test"
+      ]
     }
   ],
   "projectName": "skbase",

skbase/lookup/tests/test_lookup.py

@@ -37,13 +37,13 @@
     SKBASE_PUBLIC_CLASSES_BY_MODULE,
     SKBASE_PUBLIC_FUNCTIONS_BY_MODULE,
     SKBASE_PUBLIC_MODULES,
-    ClassWithABTrue,
-    Parent,
 )
-from skbase.tests.mock_package.test_mock_package import (
+from skbase.tests.mock_package import (
     MOCK_PACKAGE_OBJECTS,
+    ClassWithABTrue,
     CompositionDummy,
     NotABaseObject,
+    Parent,
 )
 
 __author__: List[str] = ["RNKuhns", "fkiraly"]
@@ -1033,7 +1033,7 @@ def test_all_objects_class_filter(class_filter):
     """Test all_objects filters by class type as expected."""
     # Results applying filter
     objs = all_objects(
-        package_name="skbase",
+        package_name="skbase.tests.mock_package",
         return_names=True,
         as_dataframe=True,
         return_tags=None,
@@ -1047,7 +1047,7 @@ def test_all_objects_class_filter(class_filter):
 
     # Results without filter
     objs = all_objects(
-        package_name="skbase",
+        package_name="skbase.tests.mock_package",
         return_names=True,
         as_dataframe=True,
         return_tags=None,
@@ -1073,7 +1073,7 @@ def test_all_object_tag_filter(tag_filter):
     """Test all_objects filters by tag as expected."""
     # Results applying filter
     objs = all_objects(
-        package_name="skbase",
+        package_name="skbase.tests.mock_package",
         return_names=True,
         as_dataframe=True,
         return_tags=None,
@@ -1087,7 +1087,7 @@ def test_all_object_tag_filter(tag_filter):
 
     # Results without filter
     objs = all_objects(
-        package_name="skbase",
+        package_name="skbase.tests.mock_package",
         return_names=True,
         as_dataframe=True,
         return_tags=None,
@@ -1148,7 +1148,7 @@ def test_all_object_class_lookup(class_lookup, class_filter):
     """Test all_objects class_lookup parameter works as expected.."""
     # Results applying filter
     objs = all_objects(
-        package_name="skbase",
+        package_name="skbase.tests.mock_package",
         return_names=True,
         as_dataframe=True,
         return_tags=None,
@@ -1171,7 +1171,7 @@ def test_all_object_class_lookup_invalid_object_types_raises(
     # Results applying filter
     with pytest.raises(ValueError):
         all_objects(
-            package_name="skbase",
+            package_name="skbase.tests.mock_package",
             return_names=True,
             as_dataframe=True,
             return_tags=None,

skbase/testing/test_all_objects.py

@@ -745,7 +745,7 @@ def test_object_tags(self, object_class):
             assert isinstance(tags, dict), msg
             assert len(tags) > 0, f"_tags dict of class {object_class} is empty"
             if self.valid_tags is None:
-                invalid_tags = tags
+                invalid_tags = []
             else:
                 invalid_tags = [
                     tag for tag in tags.keys() if tag not in self.valid_tags

skbase/tests/mock_package/__init__.py

@@ -3,4 +3,17 @@
 
 from typing import List
 
+from .test_fixtures import Child  # noqa: F401
+from .test_fixtures import ClassWithABTrue  # noqa: F401
+from .test_fixtures import Parent  # noqa: F401
+from .test_mock_package import MOCK_PACKAGE_OBJECTS  # noqa: F401
+from .test_mock_package import AnotherClass  # noqa: F401
+from .test_mock_package import CompositionDummy  # noqa: F401
+from .test_mock_package import InheritsFromBaseObject  # noqa: F401
+from .test_mock_package import NotABaseObject  # noqa: F401
+
+__all__: List[str] = [
+    "MOCK_PACKAGE_OBJECTS",
+]
+
 __author__: List[str] = ["fkiraly", "RNKuhns"]

skbase/tests/mock_package/subpkg/__init__.py

@@ -0,0 +1,3 @@
+"""Subpackage in mock package to test recursive walking."""
+
+__all__ = ["test_module_b"]

skbase/tests/mock_package/subpkg/test_module_b.py

@@ -0,0 +1,10 @@
+# -*- coding: utf-8 -*-
+"""Module inside subpackage to test recursive discovery."""
+
+
+def subpkg_fn():
+    """Return the string "ok" to indicate functionality."""
+    return "ok"
+
+
+__all__ = ["subpkg_fn"]

skbase/tests/mock_package/test_fixtures.py

@@ -0,0 +1,47 @@
+# -*- coding: utf-8 -*-
+"""Additional fixture classes for the mock package used in lookup tests."""
+
+from typing import List
+
+from skbase.base import BaseObject
+
+__author__: List[str] = ["fkiraly", "RNKuhns"]
+
+
+class Parent(BaseObject):
+    """Parent class to test tag inheritance and class filters."""
+
+    _tags = {"A": "1", "B": 2, "C": 1234, "3": "D"}
+
+    def __init__(self, a="something", b=7, c=None):
+        """Initialize the fixture with simple attributes."""
+        self.a = a
+        self.b = b
+        self.c = c
+        super().__init__()
+
+    def some_method(self):
+        """Placeholder method used in tests."""
+        pass
+
+
+class Child(Parent):
+    """Child class that overrides some tags."""
+
+    _tags = {"A": 42, "3": "E"}
+    __author__ = ["fkiraly", "RNKuhns"]
+
+    def some_method(self):
+        """Child placeholder method used in tests."""
+        pass
+
+
+class ClassWithABTrue(Parent):
+    """Child class that sets A and B tags to True."""
+
+    _tags = {"A": True, "B": True}
+    __author__ = ["fkiraly", "RNKuhns"]
+
+    def some_method(self):
+        """Placeholder method used in tests."""
+        pass

skbase/tests/mock_package/test_mock_package.py

@@ -6,6 +6,8 @@
 
 from skbase.base import BaseObject
 
+from .test_fixtures import Child, ClassWithABTrue, Parent
+
 __all__: List[str] = [
     "CompositionDummy",
     "InheritsFromBaseObject",
@@ -72,4 +74,7 @@ class _NonPublicClass(BaseObject):
     CompositionDummy,
     InheritsFromBaseObject,
     _NonPublicClass,
+    Parent,
+    Child,
+    ClassWithABTrue,
 ]

skbase/tests/mock_package/test_module_public.py

@@ -0,0 +1,26 @@
+# -*- coding: utf-8 -*-
+"""Public module in mock package with decorated and plain functions."""
+
+from functools import wraps
+
+
+def simple_function(x):
+    """Double the given input and return the result."""
+    return x * 2
+
+
+def my_decorator(func):
+    @wraps(func)
+    def wrapper(*args, **kwargs):
+        return func(*args, **kwargs)
+
+    return wrapper
+
+
+@my_decorator
+def decorated_function(y):
+    """Increment the given input by one and return the result."""
+    return y + 1
+
+
+__all__ = ["simple_function", "decorated_function"]

skbase/tests/mock_package/test_private_module.py

@@ -0,0 +1,18 @@
+# -*- coding: utf-8 -*-
+"""Non-public module in mock package; contains a non-public BaseObject subclass.
+
+This module's class name begins with an underscore and should be ignored by
+`all_objects` when `exclude_non_public_items` is True.
+"""
+
+from skbase.base import BaseObject
+
+
+class _PrivateThing(BaseObject):
+    """A non-public BaseObject subclass that should be ignored by discovery."""
+
+    def __init__(self):
+        super().__init__()
+
+
+__all__ = ["_PrivateThing"]

skbase/tests/test_lookup.py

@@ -33,3 +33,32 @@ def test_all_objects_returns_class_name_for_alias(tmp_path, monkeypatch):
 
     sys.modules.pop(f"{pkg_name}.module", None)
     sys.modules.pop(pkg_name, None)
+
+
+def test_all_objects_filter_tags_returns_matches(tmp_path, monkeypatch):
+    """Test that all_objects honors the filter_tags argument.
+
+    Ensure the function returns matching classes when a tag is provided.
+    """
+    pkg_name = "pkg_tag_case"
+    root = tmp_path / pkg_name
+    root.mkdir()
+
+    (root / "__init__.py").write_text(
+        "from .module import MyClass\n" "__all__ = ['MyClass']\n"
+    )
+    (root / "module.py").write_text(
+        "from skbase.base import BaseObject\n\n"
+        "class MyClass(BaseObject):\n"
+        "    _tags = {'special_tag': True}\n"
+    )
+    monkeypatch.syspath_prepend(str(tmp_path))
+    importlib.invalidate_caches()
+
+    objs = all_objects(package_name=pkg_name, path=str(root), filter_tags="special_tag")
+    assert len(objs) == 1
+    name, klass = objs[0]
+    assert name == klass.__name__ == "MyClass"
+
+    sys.modules.pop(f"{pkg_name}.module", None)
+    sys.modules.pop(pkg_name, None)