Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion skbase/base/_meta.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@ def set_params(self, **kwargs):
"""
# Use tag interface that will be available when mixin is used
named_object_attr = self.get_tag("named_object_parameters") # type: ignore
return self._set_params(named_object_attr, **kwargs)
result = self._set_params(named_object_attr, **kwargs)
self.reset() # <- Call reset after parameters are set
return result

def _get_fitted_params(self):
"""Get fitted parameters.
Expand Down
20 changes: 20 additions & 0 deletions skbase/tests/test_meta.py
Original file line number Diff line number Diff line change
Expand Up @@ -168,3 +168,23 @@ def test_metaestimator_composite(long_steps):

meta_est.set_params(bar__b="something else")
assert meta_est.get_params()["bar__b"] == "something else"


def test_basemetaobject_set_params_uses_baseobject_reset():
"""Test that BaseMetaObject.set_params correctly triggers BaseObject.reset."""

class ResetCheckMetaObject(BaseMetaObject):
def __init__(self, a=1, steps=None):
self.a = a
self.steps = steps if steps is not None else []
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not compliant with the API - self params should never be changed.

There should also be steps_ etc, and we should also do get_params in the test.

self.set_tags(foo="bar") # optional tag use
super().__init__()
self.b_ = 2 * self.a # Dependent attribute

obj = ResetCheckMetaObject()
assert obj.b_ == 2

# set_params should update 'a' and trigger reset (from BaseObject) which updates 'b_'
obj.set_params(a=10)
assert obj.a == 10
assert obj.b_ == 20 # This confirms reset updated the dependent value