Skip to content

feat(tokens): define primitive token foundations#248

Open
3o14 wants to merge 2 commits intodev/side-v2from
docs/#220-primitive-token-wonju
Open

feat(tokens): define primitive token foundations#248
3o14 wants to merge 2 commits intodev/side-v2from
docs/#220-primitive-token-wonju

Conversation

@3o14
Copy link
Copy Markdown
Member

@3o14 3o14 commented Apr 22, 2026

Summary

SIDE v2 디자인 토큰의 Primitive 레이어(원시값 계층)를 JSON으로 정의합니다.

Semantic 토큰 설계(#221)의 선행 작업입니다.

  • tokens/primitive/color.json — 10개 hue × 11단계(50~950) + black/white
  • tokens/primitive/spacing.json — 4px 기본 단위, space-050~900
  • tokens/primitive/radius.json — none / sm / md / lg / xl / full
  • tokens/primitive/typography.json — fontFamily / fontSize / fontWeight / lineHeight

Notes

  • Semantic 의미 없는 plain 팔레트만 정의. 색상 역할 매핑은 #221에서 진행
  • 컨벤션 문서(.github/decisions/token-naming-convention.md) 준수
    • JSON 키: 중첩 객체 (color.gray.500)
    • CSS var 변환: -side-color-gray-500
  • border / shadow / z-index / motion 등은 이번 범위 외

Related

closes #220

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 22, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • main
  • release/v1

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: d640ed05-94d5-4163-93dc-2832cb69af3a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/#220-primitive-token-wonju

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 22, 2026

⚠️ No Changeset found

Latest commit: 9d6de69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@3o14
Copy link
Copy Markdown
Member Author

3o14 commented Apr 22, 2026

외부에 노출되는 API 변경점은 없어서 changeset은 생략했습니다.

개발자 리뷰는 따로 불필요해서 PR 리뷰는 정민님께서 봐주시면 좋을 것 같습니다! @haedawn

Copy link
Copy Markdown
Contributor

@froggy1014 froggy1014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3o14

아직 디자인시스템에 Foundation 정의가 되있지 않은 상황인데 어떤 값을 기준으로 작성하셨는지 알 수 있을까요 ~ ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants