Skip to content

fix(Tooltip): 접근성(a11y) 개선 및 스타일 코드 개선 #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
minji0214 wants to merge 7 commits into
base: dev/side-v2
Choose a base branch
from
Open

fix(Tooltip): 접근성(a11y) 개선 및 스타일 코드 개선 #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f3446f5
fix(tooltip): add aria-label for screen readers
minji0214 Apr 19, 2026
95993f5
refactor(tooltip): migrate styles to vanilla-extract recipe
minji0214 Apr 19, 2026
01c484f
test(tooltip): improve accessibility test coverage
minji0214 Apr 19, 2026
92d3bb3
refactor(tooltip): use enum instead of string literal
minji0214 Apr 19, 2026
3608fb0
fix(tooltip): resolve type import error
minji0214 Apr 19, 2026
8bf2e74
test(tooltip): translate test descriptions to English
minji0214 Apr 20, 2026
4154442
chore(tooltip): remove export and add changeset
minji0214 Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wet-pants-train.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@sipe-team/tooltip": patch
---

improve accessibility and refactor styles for Tooltip
1 change: 1 addition & 0 deletions packages/tooltip/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
},
"dependencies": {
"@radix-ui/react-slot": "catalog:",
"@vanilla-extract/recipes": "catalog:",
"clsx": "catalog:"
},
"devDependencies": {
Expand Down
214 changes: 109 additions & 105 deletions packages/tooltip/src/Tooltip.css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,120 +1,124 @@
import { style, styleVariants } from '@vanilla-extract/css';
import { style } from '@vanilla-extract/css';
import { recipe } from '@vanilla-extract/recipes';

export const tooltip = style({
position: 'fixed',
backgroundColor: 'var(--tooltip-bg-color, #000000)',
color: '#ffffff',
padding: '8px 12px',
borderRadius: '8px',
fontSize: '12px',
lineHeight: 1.5,
whiteSpace: 'normal',
wordWrap: 'break-word',
maxWidth: '250px',
boxShadow: '0 4px 8px rgba(0, 0, 0, 0.2)',
zIndex: 1000,
opacity: 0,
transform: 'scale(0.95)',
transition: 'opacity 0.3s ease, transform 0.3s ease',
pointerEvents: 'none',
selectors: {
'&.visible': {
opacity: 1,
transform: 'scale(1)',
pointerEvents: 'auto',
},
'&::after': {
content: '""',
position: 'absolute',
width: 0,
height: 0,
borderStyle: 'solid',
},
},
});

export const placement = styleVariants({
'top-left': {
export const tooltip = recipe({
base: {
position: 'fixed',
backgroundColor: 'var(--tooltip-bg-color, #000000)',
color: '#ffffff',
padding: '8px 12px',
borderRadius: '8px',
fontSize: '12px',
lineHeight: 1.5,
whiteSpace: 'normal',
wordWrap: 'break-word',
maxWidth: '250px',
boxShadow: '0 4px 8px rgba(0, 0, 0, 0.2)',
zIndex: 1000,
opacity: 0,
transform: 'scale(0.95)',
transition: 'opacity 0.3s ease, transform 0.3s ease',
pointerEvents: 'none',
selectors: {
'&::after': {
bottom: '-6px',
left: '8px',
borderWidth: '6px 6px 0 6px',
borderColor: 'var(--tooltip-bg-color, #000000) transparent transparent transparent',
'&.visible': {
opacity: 1,
transform: 'scale(1)',
pointerEvents: 'auto',
},
},
},
'top-right': {
selectors: {
'&::after': {
bottom: '-6px',
right: '8px',
borderWidth: '6px 6px 0 6px',
borderColor: 'var(--tooltip-bg-color, #000000) transparent transparent transparent',
content: '""',
position: 'absolute',
width: 0,
height: 0,
borderStyle: 'solid',
},
},
},
'bottom-left': {
selectors: {
'&::after': {
top: '-6px',
left: '8px',
borderWidth: '0 6px 6px 6px',
borderColor: 'transparent transparent var(--tooltip-bg-color, #000000) transparent',
variants: {
placement: {
'top-left': {
selectors: {
'&::after': {
bottom: '-6px',
left: '8px',
borderWidth: '6px 6px 0 6px',
borderColor: 'var(--tooltip-bg-color, #000000) transparent transparent transparent',
},
},
},
},
},
'bottom-right': {
selectors: {
'&::after': {
top: '-6px',
right: '8px',
borderWidth: '0 6px 6px 6px',
borderColor: 'transparent transparent var(--tooltip-bg-color, #000000) transparent',
'top-right': {
selectors: {
'&::after': {
bottom: '-6px',
right: '8px',
borderWidth: '6px 6px 0 6px',
borderColor: 'var(--tooltip-bg-color, #000000) transparent transparent transparent',
},
},
},
},
},
top: {
selectors: {
'&::after': {
bottom: '-6px',
left: '50%',
transform: 'translateX(-50%)',
borderWidth: '6px 6px 0 6px',
borderColor: 'var(--tooltip-bg-color, #000000) transparent transparent transparent',
'bottom-left': {
selectors: {
'&::after': {
top: '-6px',
left: '8px',
borderWidth: '0 6px 6px 6px',
borderColor: 'transparent transparent var(--tooltip-bg-color, #000000) transparent',
},
},
},
},
},
bottom: {
selectors: {
'&::after': {
top: '-6px',
left: '50%',
transform: 'translateX(-50%)',
borderWidth: '0 6px 6px 6px',
borderColor: 'transparent transparent var(--tooltip-bg-color, #000000) transparent',
'bottom-right': {
selectors: {
'&::after': {
top: '-6px',
right: '8px',
borderWidth: '0 6px 6px 6px',
borderColor: 'transparent transparent var(--tooltip-bg-color, #000000) transparent',
},
},
},
},
},
left: {
selectors: {
'&::after': {
right: '-6px',
top: '50%',
transform: 'translateY(-50%)',
borderWidth: '6px 0 6px 6px',
borderColor: 'transparent transparent transparent var(--tooltip-bg-color, #000000)',
top: {
selectors: {
'&::after': {
bottom: '-6px',
left: '50%',
transform: 'translateX(-50%)',
borderWidth: '6px 6px 0 6px',
borderColor: 'var(--tooltip-bg-color, #000000) transparent transparent transparent',
},
},
},
},
},
right: {
selectors: {
'&::after': {
left: '-6px',
top: '50%',
transform: 'translateY(-50%)',
borderWidth: '6px 6px 6px 0',
borderColor: 'transparent var(--tooltip-bg-color, #000000) transparent transparent',
bottom: {
selectors: {
'&::after': {
top: '-6px',
left: '50%',
transform: 'translateX(-50%)',
borderWidth: '0 6px 6px 6px',
borderColor: 'transparent transparent var(--tooltip-bg-color, #000000) transparent',
},
},
},
left: {
selectors: {
'&::after': {
right: '-6px',
top: '50%',
transform: 'translateY(-50%)',
borderWidth: '6px 0 6px 6px',
borderColor: 'transparent transparent transparent var(--tooltip-bg-color, #000000)',
},
},
},
right: {
selectors: {
'&::after': {
left: '-6px',
top: '50%',
transform: 'translateY(-50%)',
borderWidth: '6px 6px 6px 0',
borderColor: 'transparent var(--tooltip-bg-color, #000000) transparent transparent',
},
},
},
},
},
Expand Down
Loading
Loading