Skip to content

Promoted cluster graceful-shutdown and cluster graceful-startup #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noctarius wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Promoted cluster graceful-shutdown and cluster graceful-startup #961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions simplyblock_cli/cli-reference.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1393,7 +1393,6 @@ commands:
type: str
- name: graceful-shutdown
help: "Initiates a graceful shutdown of a cluster's storage nodes."
private: true
arguments:
- name: "cluster_id"
help: "The cluster id."
Expand All @@ -1402,7 +1401,6 @@ commands:
completer: _completer_get_cluster_list
- name: graceful-startup
help: "Initiates a graceful startup of a cluster's storage nodes."
private: true
arguments:
- name: "cluster_id"
help: "The cluster id."
Expand Down
18 changes: 4 additions & 14 deletions simplyblock_cli/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,10 +367,8 @@ def init_cluster(self):
self.init_cluster__update_fabric(subparser)
self.init_cluster__check(subparser)
self.init_cluster__update(subparser)
if self.developer_mode:
self.init_cluster__graceful_shutdown(subparser)
if self.developer_mode:
self.init_cluster__graceful_startup(subparser)
self.init_cluster__graceful_shutdown(subparser)
self.init_cluster__graceful_startup(subparser)
self.init_cluster__list_tasks(subparser)
self.init_cluster__cancel_task(subparser)
self.init_cluster__get_subtasks(subparser)
Expand Down Expand Up @@ -1268,17 +1266,9 @@ def run(self):
elif sub_command in ['update']:
ret = self.cluster__update(sub_command, args)
elif sub_command in ['graceful-shutdown']:
if not self.developer_mode:
print("This command is private.")
ret = False
else:
ret = self.cluster__graceful_shutdown(sub_command, args)
ret = self.cluster__graceful_shutdown(sub_command, args)
elif sub_command in ['graceful-startup']:
if not self.developer_mode:
print("This command is private.")
ret = False
else:
ret = self.cluster__graceful_startup(sub_command, args)
ret = self.cluster__graceful_startup(sub_command, args)
elif sub_command in ['list-tasks']:
ret = self.cluster__list_tasks(sub_command, args)
elif sub_command in ['cancel-task']:
Expand Down
Loading