feat: maintenance mode for web#2740
Merged
Merged
Conversation
cquintana92
force-pushed
the
feature/maintenance-mode
branch
from
1f7e31f to
3bcb6cd
Compare
|
|
||
| @app.before_request | ||
| def maintenance(): | ||
| if ( |
Collaborator
There was a problem hiding this comment.
nit: you could convert this to an if not and return the jsonify error below and then everything would 503 except these no?
oliver-gordon
approved these changes
Jun 4, 2026
acasajus
reviewed
Jun 4, 2026
acasajus
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a "Maintenance Mode" for the webapp, where all requests (except static and healthcheck) return 503 and show a maintenance page. It does it by extracting logic from
server.pyand moving it intosimplelogin_app.pyalongside amaintenance_app.py, makingserver.pydetermine whether it's in maintenance mode based on the newconfig.pydirective. If in maintenance mode, the web app doesn't even try to connect to the database, so it always works regardless of the connection status.Maintenance mode for
email_handler.pyis not implemented in this PR as it requires some bigger changes.