Use fixed width in matrix vis for space-padded fixed-length string arrays - #2029
Merged
Conversation
axelboc
changed the title
Member
|
The issue is still there for null-padded strings (see the dataset I provide in #2026) Should we do the same for these? |
Contributor
Author
|
Yeah I guess relying on the length at all is not very reliable. I'll just use a default width, then? |
Member
We can compromise by computing the expected length and clamp it to a maximum value so the cell still looks like a cell on most screens (e.g. using the 300px value). The user can anyway tune the width manually afterwards. |
axelboc
force-pushed
the
fixed-length
branch
2 times, most recently
from
August 5, 2026 08:49
ea4a4d9 to
4ee2ffb
Compare
loichuder
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2026
I added a check for space padding when computing the default cell width.
In all of our test files, I couldn't find one with an array of fixed-length strings! 😂