fix(connect): don't quit a Figma that is already debuggable

[clementcopper]

The problem

connect quits and relaunches Figma unconditionally:

// src/commands/setup.js
stopDaemon();

console.log(chalk.blue('Starting Figma...'));
try {
  killFigma();
  await new Promise(r => setTimeout(r, 500));
} catch {}

startFigma();

That runs even when the CDP port is already answering and nothing needs to happen to Figma at all — which is the common case once you're set up. The cost is the user's window arrangement, their zoom/scroll position, and whatever hasn't synced yet. Running connect a second time "just to be sure" is a normal thing to do, and it shouldn't be destructive.

It also affects the recovery path people are told to take: when a command times out, restarting the daemon is usually enough, but connect looks like the safer, more thorough option — and it's the one that costs you your session.

The change

connect probes the CDP port first and branches on what it finds:

CDP reachable	Figma running	Action
yes	—	reuse — leave Figma alone, just start the daemon
no	yes	needs-quit — ask the user to quit (they may have unsaved work; killing it for them is not our call)
no	no	start-fresh — patch if needed and launch, exactly as before

The start-fresh branch is the existing code, unchanged. Only the guard in front of it is new.

The decision itself is a pure function in src/lib/connect-plan.js, following the pattern of browserDebugArgs / tests/browser-mode.test.js, so it's unit-tested without a Figma or an open port:

resolveConnectAction({ cdpReachable, figmaRunning })
// → 'reuse' | 'needs-quit' | 'start-fresh'

The process probe uses the existing isFigmaRunning() from src/platform.js, so it works on macOS, Windows and Linux. The port comes from getCdpPort(), so --port / FIGMA_PORT are honored.

Verification

• npm test → 525 passing, including 4 new cases in tests/connect-plan.test.js
• All three branches confirmed against a real Figma Desktop:
  • reuse — Figma's PID and start time identical before and after connect; output ✓ Figma already running (left untouched), daemon reconnected
  • needs-quit — Figma running with an unpatched app.asar: connect printed the quit prompt and left the process alone
  • start-fresh — no Figma running: patched and launched as before

Notes

Happy to adjust the wording of the needs-quit message, or to make it offer a --force flag that restores the old quit-and-relaunch behavior, if you'd rather keep an escape hatch.