Unsubscribe ImageCropper's Application.Idle handler on Dispose#1532
Draft
imnasnainaec wants to merge 1 commit into
Draft
Unsubscribe ImageCropper's Application.Idle handler on Dispose#1532imnasnainaec wants to merge 1 commit into
imnasnainaec wants to merge 1 commit into
Conversation
ImageCropper subscribed to the static Application.Idle event in its constructor but never unsubscribed in Dispose, so the handler could still fire after the control was disposed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageCropper subscribed to the static
Application.Idleevent in its constructor but never unsubscribed inDispose, so the handler could still fire after the control was disposed.Added tests is a smoke test that passes even without this fix. A true regression unit test is harder to produce.
This change is