Repository navigation
fix(docker): use JSON notation for HEALTHCHECK CMD (hadolint DL3025) - #52
Merged
guillaume-sainthillier merged 1 commit intoSep 16, 2026
Merged
Conversation
hadolint-action 3.5.0 ships a newer hadolint that enforces DL3025 on the HEALTHCHECK instructions, failing CI on every open PR. The shell form is wrapped in an explicit /bin/sh -c rather than converted to a bare exec form, because '|| exit 1' normalises curl's exit status to 1. Docker reserves healthcheck exit code 2, and bare 'curl -f' can return 2, 7, 22 or 28, so dropping the shell would change healthcheck semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hadolint-action3.5.0 (PRs #49 / #51) ships a newer hadolint that enforces DL3025 on theHEALTHCHECKinstructions, producing 36 warnings and failinglint-dockerfileson every open PR (failure-threshold: warning).All 36 Dockerfiles are converted to JSON notation:
The shell is kept explicitly rather than using a bare exec form (
CMD ["curl", "-f", ...]) because|| exit 1normalises the exit status. Docker's healthcheck contract reserves exit code 2, and barecurl -fcan exit 2, 7, 22 or 28 — so dropping the shell would subtly change healthcheck behaviour.Verified locally:
hadolint --failure-threshold warning */Dockerfileexits 0, anddocker build --checkreports no warnings.