added pubkey bidirectional cache#9345
Open
Fraccaman wants to merge 2 commits into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #8783
Proposed Changes
This PR implements my understanding of how to fix the scenario described in #8783.
As described in the issue, this PR introduced a bidirectional cache between
builder_indexandpublic_key. It then leverage the new data structure to avoid theO(n)search.Additional Info
add_builder_to_registry. Here, a new builder is added to the list. My assumption is that the builder list 1) never shrinks 2) builders pubkeys never change. This means that the cache can only miss some entries from the builder list but will never have more entries that the builder list.Let me know if the logic is wrong or if anything should be modified :)