Gloas dont enforce peer column custody on block import#9341
Open
eserilev wants to merge 1 commit into
Open
Conversation
…o have columns available
eserilev
added
gloas
syncing
ready-for-review
pawanjay176
reviewed
May 22, 2026
Member
pawanjay176
left a comment
pawanjay176
left a comment
There was a problem hiding this comment.
LGTM, other than a small suggestion.
| // have the block but not yet imported the envelope and data columns. | ||
| // Don't enforce max_responses in this case. | ||
| lookup_peers.contains(&peer_id) | ||
| && !cx |
Member
There was a problem hiding this comment.
can do
!cx.fork_context.current_fork_name().gloas_enabled()
This is not strictly correct because we should be checking the block's slot and not current slot clock. But given that #9155 is overhauling the entire thing, i'm fine with this to help with the devnet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Peers that advertise that they have imported a block may not have the columns for that slot available post-Gloas. Ensure that we dont penalize them.