Skip to content

Feat: add async backend querying#50

Draft
alexluck-sift wants to merge 2 commits intomainfrom
al/feat/async-backend-querying
Draft

Feat: add async backend querying#50
alexluck-sift wants to merge 2 commits intomainfrom
al/feat/async-backend-querying

Conversation

@alexluck-sift
Copy link
Copy Markdown
Contributor

Pull Request

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please check the boxes that apply to this pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Test A
  • Test B

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please add screenshots to help explain your changes if applicable.

Comment thread pkg/plugin/async_query.go

// debugAsyncDelay adds an artificial delay before executing async queries.
// Set to e.g. 30*time.Second to manually test polling, then set back to 0.
debugAsyncDelay = 5 * time.Second // TODO: SET BACK TO ZERO BEFORE RELEASE
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will set back to 0, but at 5s for playing around with purposes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant