refactor(eslint): drop use of deprecated method#44
Open
chintankavathia wants to merge 1 commit intomainfrom
Open
refactor(eslint): drop use of deprecated method#44chintankavathia wants to merge 1 commit intomainfrom
chintankavathia wants to merge 1 commit intomainfrom
Conversation
spike-rabbit
requested changes
Oct 14, 2025
Member
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
defineConfig is rather new, it requires eslint 9.22.0. See https://github.com/eslint/eslint/releases/tag/v9.22.0.
Please make update the peer dependencies and make this a breaking change.
ljanner
requested changes
Apr 2, 2026
chintankavathia
force-pushed
the
refactor/remove-deprecated
branch
from
f7b25a5 to
b9dcf71
Compare
ljanner
requested changes
Apr 8, 2026
Member
ljanner
left a comment
ljanner
left a comment
There was a problem hiding this comment.
Only one small detail, otherwise looks good 👍
chintankavathia
force-pushed
the
refactor/remove-deprecated
branch
from
b9dcf71 to
29cf5aa
Compare
replaces deprecated `typescriptEslint.config` method of `typescript-eslint` with `defineConfig` of `eslint/config`
ljanner
force-pushed
the
refactor/remove-deprecated
branch
from
29cf5aa to
3238d24
Compare
spike-rabbit
requested changes
Apr 15, 2026
Member
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
We still need the breaking change.
Currently we have this in the peerDependencies:
This must be at least 9.22.0 because before defineConfig was not available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces deprecated
typescriptEslint.configmethod oftypescript-eslintwithdefineConfigofeslint/config