Skip to content

fix(form): correct misleading validation messages for date/time bounds #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chintankavathia wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

fix(form): correct misleading validation messages for date/time bounds #1894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions projects/element-ng/form/si-form-validation-error.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,24 +47,24 @@ export const buildDefaults = (): SiFormValidationErrorMapper => ({
() => $localize`:@@SI_FORM_CONTAINER.ERROR.DATE_FORMAT_START:Invalid start date`
),
maxDate: t(
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MAX_DATE:Date prior to {{maxString}} required`
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MAX_DATE:Date on or before {{maxString}} required`
),
minDate: t(
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MIN_DATE:Date after {{minString}} required`
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MIN_DATE:Date on or after {{minString}} required`
),
maxTime: t(
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MAX_TIME:Time prior to {{maxString}} required`
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MAX_TIME:Time on or before {{maxString}} required`
),
minTime: t(
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MIN_TIME:Time after {{minString}} required`
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MIN_TIME:Time on or after {{minString}} required`
),
rangeAfterMaxDate: t(
() =>
$localize`:@@SI_FORM_CONTAINER.ERROR.RANGE_AFTER_MAX_DATE:Period prior to {{maxString}} required`
$localize`:@@SI_FORM_CONTAINER.ERROR.RANGE_AFTER_MAX_DATE:Period on or before {{maxString}} required`
),
rangeBeforeMinDate: t(
() =>
$localize`:@@SI_FORM_CONTAINER.ERROR.RANGE_BEFORE_MIN_DATE:Period after {{minString}} required`
$localize`:@@SI_FORM_CONTAINER.ERROR.RANGE_BEFORE_MIN_DATE:Period on or after {{minString}} required`
),
Comment on lines 49 to 68
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the UX writing guidelines, validation messages should use telegram style and be as concise as possible. The word "required" at the end of these messages makes them full sentences and is superfluous, as the context of a validation error already implies the requirement. Removing it also improves consistency with other validators in this file (like max and maxlength) which do not use "required" at the end.

Suggested change
maxDate: t(
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MAX_DATE:Date prior to {{maxString}} required`
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MAX_DATE:Date on or before {{maxString}} required`
),
minDate: t(
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MIN_DATE:Date after {{minString}} required`
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MIN_DATE:Date on or after {{minString}} required`
),
maxTime: t(
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MAX_TIME:Time prior to {{maxString}} required`
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MAX_TIME:Time on or before {{maxString}} required`
),
minTime: t(
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MIN_TIME:Time after {{minString}} required`
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MIN_TIME:Time on or after {{minString}} required`
),
rangeAfterMaxDate: t(
() =>
$localize`:@@SI_FORM_CONTAINER.ERROR.RANGE_AFTER_MAX_DATE:Period prior to {{maxString}} required`
$localize`:@@SI_FORM_CONTAINER.ERROR.RANGE_AFTER_MAX_DATE:Period on or before {{maxString}} required`
),
rangeBeforeMinDate: t(
() =>
$localize`:@@SI_FORM_CONTAINER.ERROR.RANGE_BEFORE_MIN_DATE:Period after {{minString}} required`
$localize`:@@SI_FORM_CONTAINER.ERROR.RANGE_BEFORE_MIN_DATE:Period on or after {{minString}} required`
),
maxDate: t(
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MAX_DATE:Date on or before {{maxString}}`
),
minDate: t(
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MIN_DATE:Date on or after {{minString}}`
),
maxTime: t(
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MAX_TIME:Time on or before {{maxString}}`
),
minTime: t(
() => $localize`:@@SI_FORM_CONTAINER.ERROR.MIN_TIME:Time on or after {{minString}}`
),
rangeAfterMaxDate: t(
() =>
$localize`:@@SI_FORM_CONTAINER.ERROR.RANGE_AFTER_MAX_DATE:Period on or before {{maxString}}`
),
rangeBeforeMinDate: t(
() =>
$localize`:@@SI_FORM_CONTAINER.ERROR.RANGE_BEFORE_MIN_DATE:Period on or after {{minString}}`
),
References
  1. Use as few words as possible. (link)
  2. Avoid full sentences on interactive UI pages — use telegram style without a trailing full stop. (link)

// Time units
hours: t(
Expand Down
Loading