Skip to content

build(gh-actions): prevent inline vars in workflows #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
spike-rabbit wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

build(gh-actions): prevent inline vars in workflows #1864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,9 @@ jobs:
GIT_COMMITTER_EMAIL: 'simpl.si@siemens.com'
GITHUB_TOKEN: ${{ secrets.ELEMENT_BOT_GITHUB_TOKEN }}
- id: check_release
env:
BEFORE_TAG: ${{ steps.before_release.outputs.before_tag }}
run: |
BEFORE_TAG="${{ steps.before_release.outputs.before_tag }}"
AFTER_TAG=$(git describe --tags --abbrev=0 2>/dev/null || echo "")

if [[ -n "$AFTER_TAG" && "$AFTER_TAG" != "$BEFORE_TAG" ]]; then
Expand Down
13 changes: 9 additions & 4 deletions .github/workflows/vrt-update.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,17 @@ jobs:
steps:
- name: Check execution conditions and set target ref
id: check
env:
EVENT_NAME: ${{ github.event_name }}
INPUT_REF: ${{ inputs.ref }}
HEAD_REF: ${{ github.head_ref }}
run: |
echo "should-run=true" >> $GITHUB_OUTPUT
if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then
echo "target-ref=${{ inputs.ref }}" >> $GITHUB_OUTPUT
if [ "$EVENT_NAME" = "workflow_dispatch" ]; then
echo "target-ref=$INPUT_REF" >> $GITHUB_OUTPUT
else
# For PR re-runs, use the head ref
echo "target-ref=${{ github.head_ref }}" >> $GITHUB_OUTPUT
echo "target-ref=$HEAD_REF" >> $GITHUB_OUTPUT
fi

# As we are in another container, we need to install LFS manually.
Expand Down Expand Up @@ -179,10 +183,11 @@ jobs:
PLAYWRIGHT_WEB_SERVER_TIMEOUT: 120000

- name: Create snapshots archive
env:
BRANCH_NAME: ${{ inputs.ref || github.ref_name }}
run: |
# Create a timestamped archive of the updated snapshots
TIMESTAMP=$(date +"%Y%m%d-%H%M%S")
BRANCH_NAME="${{ inputs.ref || github.ref_name }}"

# Sanitize branch name by replacing invalid characters for artifact names
# Replace forward slashes, colons, and other invalid characters with hyphens
Expand Down
Loading