Skip to content

fix(dashboards-ng): align catalog list styles with UX guidelines#1856

Merged
timowolf merged 1 commit intomainfrom
fix/dashboards/catalog/align-with-ux
Apr 21, 2026
Merged

fix(dashboards-ng): align catalog list styles with UX guidelines#1856
timowolf merged 1 commit intomainfrom
fix/dashboards/catalog/align-with-ux

Conversation

@chintankavathia
Copy link
Copy Markdown
Member

@chintankavathia chintankavathia commented Apr 13, 2026

removed external border around catalog list to align with UX guidelines. also move scroll inside list instead of having it on outer container.


Documentation.
Examples.
Dashboards Demo.
Playwright report.

Coverage Reports:

Code Coverage

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the widget catalog component by moving overflow handling from the container div to the inner list and removing redundant CSS styles for the widget list and list group items. I have no feedback to provide.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 13, 2026

⬇️ Download VRTs

@chintankavathia chintankavathia force-pushed the fix/dashboards/catalog/align-with-ux branch 3 times, most recently from 9649aa9 to c089e43 Compare April 13, 2026 11:33
@chintankavathia chintankavathia marked this pull request as ready for review April 13, 2026 12:50
@chintankavathia chintankavathia requested review from a team as code owners April 13, 2026 12:50
Copy link
Copy Markdown
Member

@panch1739 panch1739 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chintankavathia much better now, but i noticed something...the items in the row seem to be off-center 🤔 Could we centrally align the content in relation to the row?

Image

@chintankavathia chintankavathia force-pushed the fix/dashboards/catalog/align-with-ux branch 2 times, most recently from 7f91616 to 57b0fe6 Compare April 14, 2026 10:33
@chintankavathia chintankavathia force-pushed the fix/dashboards/catalog/align-with-ux branch 3 times, most recently from 718f4ba to 5d75847 Compare April 21, 2026 09:42
removed external border around catalog list to align with UX guidelines.
also move scroll inside list instead of having it on outer container.
@chintankavathia chintankavathia force-pushed the fix/dashboards/catalog/align-with-ux branch from 5d75847 to 5a3a1e8 Compare April 21, 2026 09:46
Copy link
Copy Markdown
Member

@panch1739 panch1739 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

@timowolf timowolf added this pull request to the merge queue Apr 21, 2026
Merged via the queue into main with commit ca79c3e Apr 21, 2026
11 checks passed
@timowolf timowolf deleted the fix/dashboards/catalog/align-with-ux branch April 21, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants