use future-rs latest#698
Merged
Merged
Conversation
Contributor
|
Importing both futures git and futures_util 3.0 seems really wonky to me. The release process for futures-rs isnt really documented, but by examining these release PRs it appears taiki will manually backport some PRs from master onto the 0.3 branch and then make a release. So I suggest we put this PR on hold until either a 0.3 backport or a 0.4 release |
rukai
reviewed
Jul 8, 2022
Author
|
Marking as a draft until a new version of futures-rs is released. |
added 2 commits
July 19, 2022 12:48
conorbros
force-pushed
the
upstream-futures-rs
branch
from
b2f072e to
af3b0b9
Compare
rukai
reviewed
Aug 14, 2022
rukai
reviewed
Aug 15, 2022
conorbros
force-pushed
the
upstream-futures-rs
branch
from
3644b28 to
5d2ab8d
Compare
rukai
reviewed
Aug 15, 2022
conorbros
force-pushed
the
upstream-futures-rs
branch
from
5d2ab8d to
5f91f84
Compare
conorbros
force-pushed
the
upstream-futures-rs
branch
from
5f91f84 to
06b59eb
Compare
conorbros
force-pushed
the
upstream-futures-rs
branch
from
6389eb3 to
7b2bde0
Compare
benbromhead
approved these changes
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that rust-lang/futures-rs#2591 has been merged we can use the latest futures-rs version from git and remove the library code from our repo.
This PR is mostly just adding required traits and fixing some formatting.