Add Publishers.AgainAt.Timer.time(at:) - #30
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a convenience API to Publishers.AgainAt.Timer for converting a wall-clock Date into the scheduler’s SchedulerTimeType, enabling republish(at:) to be driven by Date values.
Changes:
- Add
Publishers.AgainAt.Timer.time(at:)to convert aDateintoContext.SchedulerTimeType. - Add overflow-clamped
TimeInterval -> nanosecondsconversion helper. - Add tests covering future date scheduling, past date behavior, and distant-future overflow behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
Sources/CombineExtensions/AgainAt.swift |
Adds Timer.time(at:) plus nanosecond conversion/clamping to safely build scheduler times from Date. |
Tests/CombineExtensionsTests/AgainAtTests.swift |
Adds new unit tests validating date-to-scheduler-time conversion behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+355
to
+363
| private extension TimeInterval { | ||
| var nanoseconds: Int { | ||
| guard self > 0 else { return 0 } | ||
| let nanoseconds = self * 1_000_000_000 | ||
| guard nanoseconds < Double(maxNanoseconds) else { | ||
| return maxNanoseconds | ||
| } | ||
| return Int(nanoseconds) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Applied in 6e636c9. The conversion now uses .rounded(.up) (ceiling) so time(at:) never schedules before the requested Date. Also added a comment on maxNanoseconds explaining the overflow headroom.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/shareup/combine-extensions/sessions/55d385ef-6ef1-45a3-9be2-b02ca7035e41 Co-authored-by: atdrendel <202402+atdrendel@users.noreply.github.com>
atdrendel
commented
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.