Repository navigation
fix: await hydration across dashboard E2E interactions - #507
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原因
PR #506 の失敗 trace では、開始日を
2026-09-に入力した時点でmain[aria-busy=true](hydration前)でした。次の入力前に hydration が完了して開始日が初期値へ戻ったため、送信時は空の終了日に正しくフォーカスしていました。focus待ち時間ではなく、テストの入力前提が崩れています。修正
waitForDashboardReadyを適用(49待機地点、履歴helperで7経路をまとめて保護)。検証
989a288のGitHub CIは全12ジョブ成功。E2E118件(shard 1:62、shard 2:56)、unit534件、integration79件が全件成功。追加した遅延hydration3件と元の失敗テストも成功しました。6de0c00(pnpm12.9.0)。#506のアプリ依存lock documentはbaseと完全一致しますが、#506自体のCIはこの修正取り込み後に別途検証が必要です。関連: #498、#506。マージは行いません。