Repository navigation
Preserve whitespace in /api/mask input - #186
Merged
Merged
Conversation
Zod's .trim() transformed the validated text, so /api/mask detected and masked the trimmed string and returned `masked` without the input's leading or trailing whitespace. The browser extension aligns `masked` against the original prompt and reported the mismatch as an unreachable server. Reject blank text with a refine instead, leaving it unchanged. Fixes #185
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #185
POST /api/maskvalidatedtextwithz.string().trim().min(1). Zod's.trim()is a transform, so the handler detected and masked the trimmed text and returnedmaskedwithout the input's leading or trailing whitespace. The browser extension alignsmaskedagainst the original prompt character by character, so a trailing\n(common in Gemini's editor) failed the check and was reported as "server didn't respond".The schema now rejects blank text with a
refineand passestextthrough unchanged. Empty and whitespace-only input still return 400validation_errorwith "text is required".Verification
" John Smith lives in Berlin\n\n": the detector receives the untrimmed text andmaskedkeeps the surrounding whitespace. It fails on the previous schema and passes with the fix.bun test(513 pass),bun run typecheckandbun run checkpass.