Skip to content

test(storybook): relax visual diff threshold for <SprayBorder> #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fire332 merged 1 commit into from
Jul 28, 2026
Merged

test(storybook): relax visual diff threshold for <SprayBorder> #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions src/lib/Button/Button.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,25 +166,40 @@
</span>
{/snippet}

<Story name="Figma Reference Variants" template={figmaReferenceVariants} />
<Story
name="Figma Reference Variants"
parameters={{ chromatic: { diffThreshold: 0.17 } }}
template={figmaReferenceVariants}
/>

<Story name="States" {template} />
<Story name="States" parameters={{ chromatic: { diffThreshold: 0.17 } }} {template} />

<Story name="With Icon" args={{ icon: bell }} {template} />
<Story
name="With Icon"
args={{ icon: bell }}
parameters={{ chromatic: { diffThreshold: 0.17 } }}
{template}
/>

<Story name="Disabled" args={{ disabled: true }} {template} />
<Story
name="Disabled"
args={{ disabled: true }}
parameters={{ chromatic: { diffThreshold: 0.17 } }}
{template}
/>

<Story name="Large CTA" template={largeCta} />
<Story name="Large CTA" parameters={{ chromatic: { diffThreshold: 0.17 } }} template={largeCta} />

<Story name="Secondary" template={secondary} />
<Story name="Secondary" parameters={{ chromatic: { diffThreshold: 0.17 } }} template={secondary} />

<Story name="Primary" template={primary} />
<Story name="Primary" parameters={{ chromatic: { diffThreshold: 0.17 } }} template={primary} />

<Story name="Underline" template={underline} />

<Story
name="Link"
args={{ href: '#about' }}
parameters={{ chromatic: { diffThreshold: 0.17 } }}
template={linkTemplate}
play={async ({ canvasElement }) => {
await expect(within(canvasElement).getByRole('link', { name: 'About' })).toHaveAttribute(
Expand All @@ -196,6 +211,7 @@

<Story
name="Layered Control"
parameters={{ chromatic: { diffThreshold: 0.17 } }}
template={layered}
play={async ({ canvasElement }) => {
const canvas = within(canvasElement);
Expand Down Expand Up @@ -244,6 +260,7 @@

<Story
name="Presentation Surface"
parameters={{ chromatic: { diffThreshold: 0.17 } }}
template={presentationSurface}
play={async ({ canvasElement }) => {
const surface = requiredElement(canvasElement, '[data-button-surface="base"]');
Expand Down
3 changes: 3 additions & 0 deletions src/lib/Button/ClipAwareButton.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
layer: 'base',
size: 'large',
},
parameters: {
chromatic: { diffThreshold: 0.17 },
},
});

function bounds(element: Element) {
Expand Down
7 changes: 6 additions & 1 deletion src/lib/LandingHero/LandingHero.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@
name="Compact Portrait"
args={LANDING_HERO_STORY_CASES.compact.args}
globals={{ viewport: { value: LANDING_HERO_STORY_CASES.compact.viewport, isRotated: false } }}
parameters={{ chromatic: { diffThreshold: 0.17 } }}
play={async ({ canvasElement }) => {
await expectAccessibleLayers(canvasElement);
await expectLandingSemantics(canvasElement);
Expand All @@ -238,6 +239,7 @@
name="Medium"
args={LANDING_HERO_STORY_CASES.medium.args}
globals={{ viewport: { value: LANDING_HERO_STORY_CASES.medium.viewport, isRotated: false } }}
parameters={{ chromatic: { diffThreshold: 0.17 } }}
play={async ({ canvasElement }) => {
await expectAccessibleLayers(canvasElement);
await expectLandingSemantics(canvasElement);
Expand All @@ -251,6 +253,7 @@
name="Expanded"
args={LANDING_HERO_STORY_CASES.expanded.args}
globals={{ viewport: { value: LANDING_HERO_STORY_CASES.expanded.viewport, isRotated: false } }}
parameters={{ chromatic: { diffThreshold: 0.17 } }}
play={async ({ canvasElement }) => {
await expectAccessibleLayers(canvasElement);
await expectLandingSemantics(canvasElement);
Expand All @@ -264,6 +267,7 @@
name="Large Desktop"
args={LANDING_HERO_STORY_CASES.large.args}
globals={{ viewport: { value: LANDING_HERO_STORY_CASES.large.viewport, isRotated: false } }}
parameters={{ chromatic: { diffThreshold: 0.17 } }}
play={async ({ canvasElement }) => {
await expectAccessibleLayers(canvasElement);
await expectLandingSemantics(canvasElement);
Expand All @@ -277,6 +281,7 @@
name="Secondary Accent"
args={{ ...LANDING_HERO_STORY_CASES.expanded.args, class: 'secondary-accent-preview' }}
globals={{ viewport: { value: LANDING_HERO_STORY_CASES.expanded.viewport, isRotated: false } }}
parameters={{ chromatic: { diffThreshold: 0.17 } }}
play={async ({ canvasElement }) => {
await expectDestinationCta(canvasElement);
await expectNoHorizontalOverflow(canvasElement);
Expand Down Expand Up @@ -304,7 +309,7 @@
globals={{
viewport: { value: LANDING_HERO_STORY_CASES.reducedMotion.viewport, isRotated: false },
}}
parameters={{ chromatic: { prefersReducedMotion: 'reduce' } }}
parameters={{ chromatic: { diffThreshold: 0.17, prefersReducedMotion: 'reduce' } }}
play={async ({ canvasElement }) => {
await expectAccessibleLayers(canvasElement);
await expectLandingSemantics(canvasElement);
Expand Down
1 change: 1 addition & 0 deletions src/lib/SprayBorder/SprayBorder.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
color: { control: 'color' },
},
parameters: {
chromatic: { diffThreshold: 0.17 },
controls: { include: ['spread', 'radius', 'density', 'seed', 'color'] },
docs: { argTypes: { include: ['spread', 'radius', 'density', 'seed', 'color'] } },
},
Expand Down