Repository navigation
Core/cli fix - #151
Merged
Merged
Core/cli fix#151
Conversation
jefBinomed
force-pushed
the
core/cli-fix
branch
from
January 16, 2026 08:34
9172f9b to
6ec7b03
Compare
kuroidoruido
force-pushed
the
core/cli-fix
branch
from
January 29, 2026 13:14
6ec7b03 to
5d50909
Compare
|
|
kuroidoruido
force-pushed
the
core/cli-fix
branch
from
January 29, 2026 13:35
0e7a550 to
7a4f507
Compare
kuroidoruido
force-pushed
the
core/cli-fix
branch
6 times, most recently
from
January 31, 2026 14:39
bbdcf0d to
d3c271b
Compare
kuroidoruido
force-pushed
the
core/cli-fix
branch
from
January 31, 2026 14:45
d3c271b to
7178f9b
Compare
kuroidoruido
force-pushed
the
core/cli-fix
branch
from
January 31, 2026 14:59
7178f9b to
7294b5a
Compare
kuroidoruido
force-pushed
the
core/cli-fix
branch
from
January 31, 2026 15:00
7294b5a to
db2d571
Compare
kuroidoruido
force-pushed
the
core/cli-fix
branch
from
February 5, 2026 15:22
322b9d9 to
85e57c9
Compare
kuroidoruido
force-pushed
the
core/cli-fix
branch
from
February 10, 2026 07:01
0ce5e45 to
4e3c75d
Compare
…ent all CLI params (#160) * fix(cli): differentiate L_006/L_007 doc examples Each rule shared the same description and example, making it unclear which part of the README example each rule actually checks. Narrow the description to what is verified and bold the checked token (lab title for L_006, command line for L_007). fixes #133 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * docs(cli): document --rootDir on every command and config key impacts - help.ts / README: --rootDir is supported by info and init-config too, not just check, but was only ever documented for check. - cli/README.md Configuration files: add an intro and an "Impacts" note per key, pointing to the exact rule codes it enables/disables (traced through check-docs.ts/check-labs.ts) instead of leaving readers guess. - Root README.md: promote the CLI from a buried feature bullet to its own top-level section right after the theme setup instructions. fixes #137 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks done
jefBinomed
added a commit
that referenced
this pull request
Sep 24, 2026
…161) S_004 was removed and folded into S_005 by #151, but that only deduplicated the check — it stayed unconditional for every slide matching the "-lab-"/"-lab.md" naming, with no way to opt out. Some labs legitimately have no command to run (browser-only, manual/UI exercises), so add an ignoreCommandCheck config key (same pattern as ignoreAssets) listing slide paths exempted from S_005/S_011. S_006 (lab slide format) still applies to those slides. fixes #139 Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
jefBinomed
added a commit
that referenced
this pull request
Sep 24, 2026
Integrate the two commits pushed to main since the ADR branch diverged (#151 core/cli fix, #161 ignoreCommandCheck) and reconcile them with the docs/steps -> slides/labs rename: - carry main's fixes (S_011, ignoreCommandCheck, L_007 guarded by labCommandPrefix, ignoreAssets) forward under the renamed identifiers (labCommandPrefix, ignoreLabsDirectories, getWorkspaceLabsPackageJson, slidesAssetPath/slidesAssetsPath) - update cli/README.md and command-check.spec.ts accordingly Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.