Skip to content

fix: focus composition input when typing#1956

Open
DonnaIsabel97 wants to merge 1 commit into
session-foundation:devfrom
DonnaIsabel97:fix-issue-460
Open

fix: focus composition input when typing#1956
DonnaIsabel97 wants to merge 1 commit into
session-foundation:devfrom
DonnaIsabel97:fix-issue-460

Conversation

@DonnaIsabel97

Copy link
Copy Markdown

First time contributor checklist:

Contributor checklist:

Description

What does this PR do?

Focuses the conversation composition input when the user starts typing a normal printable character outside the chatbar. The first typed character is preserved by using the existing composition input ref methods.

Why was this PR needed?

Typing while a conversation is open currently does nothing unless the user first clicks the chatbar or uses the existing focus shortcut. This makes composing messages feel finicky.

What are the relevant issue numbers?

Closes #460

Testing

  • Manually verified typing a normal letter outside the chatbar focuses the chatbar.
  • Manually verified the first typed character is inserted.
  • Manually verified typing inside search/input fields does not move focus to the chatbar.
  • Manually verified modifier-key shortcuts are ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typing should autofocus the chatbar

1 participant