fix: reject invalid attachment digest lengths#1955
Open
Ap4sh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
devbranchyarn readyrun passes successfullyDescription
This rejects attachment digests unless their length matches the SHA-256 digest computed for the encrypted attachment
verifyDigest()previously compared onlytheirDigest.byteLengthbytes, so a truncated digest could be accepted after the MAC check passedThe MAC check still protects the encrypted payload first, so this is a small correctness hardening fix, not a ciphertext behavior change
Added a unit test covering a valid encrypt/decrypt round trip and a truncated digest rejection
Tests:
pnpm readynpx -y node@24.12.0 node_modules/mocha/bin/mocha.js --no-config --timeout 10000 app/ts/test/session/unit/crypto/attachmentsEncrypter_test.js