Bump the workspace version to 0.70.0#4887
Open
jschwe wants to merge 1 commit into
Open
Conversation
In preperation for the freetype-sys release. This is technically a breaking change, since one can only link one freetype-sys version. We'd be fine in servoshell, but it could break third-party embedder builds, so better to be explicit and bump the version accordingly. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
jschwe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preperation for the freetype-sys release.
This is technically a breaking change, since one can only link one freetype-sys version. We'd be fine in servoshell, but it could break third-party embedder builds, so better to be explicit and bump the version accordingly.
This PR should not be merged, and instead after approval pushed as the new 0.70 branch.
We could also decide to publish as 0.69.1 and accept the potential downstream breackage, but I'd personally prefer to play it safe.
webrender_apiwouldn't need a bump since it is unchanged, so we could revert that, but if we do a major bump i thought it would make things more consistent to stick with the same number.