Skip to content

Enable @container rule for servo #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
BudiArb wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Enable @container rule for servo #351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion style/stylesheets/rule_parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,7 @@ impl<'a, 'i> AtRuleParser<'i> for NestedRuleParser<'a, 'i> {
"font-face" => {
AtRulePrelude::FontFace
},
"container" if cfg!(feature = "gecko") => {
"container" => {
Copy link
Copy Markdown
Collaborator

@Loirooriol Loirooriol Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you work on it, it may be good to keep it behind an experimental pref, like

"container" if container_enabled() => {
#[cfg(feature = "gecko")]
fn container_enabled() {
    true
}

#[cfg(feature = "servo")]
fn container_enabled() {
    static_prefs::pref!("layout.container-queries.enabled")
}

let conditions = input.parse_comma_separated(|input| {
ContainerCondition::parse(&self.context, input)
})?;
Expand Down
Loading