Use lib-util-net for SSRF host validation#1061
Merged
Merged
Conversation
Replace the in-tree SsrfValidator with the reusable io.seqera:lib-util-net library. ValidateController now maps the library SsrfValidationException to BadRequestException, preserving the existing HTTP 400 response. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the SSRF host validator from Wave into the reusable, pure-Java library
io.seqera:lib-util-net(published as0.1.0) and consumes it back here.Changes
io.seqera:lib-util-net:0.1.0ValidateControllernow callsio.seqera.util.net.SsrfValidatorand maps the library'sSsrfValidationExceptiontoBadRequestException, preserving the existing HTTP 400 responseSsrfValidator.groovyand its test (moved to the library)Notes
nullguard after URL host extraction, sinceSet.ofrejectscontains(null)).lib-util-netand pass in libseqera CI.🤖 Generated with Claude Code