Skip to content

fix: Export type PublicKey to allow type declarations#1368

Open
jameshfisher wants to merge 1 commit intosendgrid:mainfrom
jameshfisher:patch-1
Open

fix: Export type PublicKey to allow type declarations#1368
jameshfisher wants to merge 1 commit intosendgrid:mainfrom
jameshfisher:patch-1

Conversation

@jameshfisher
Copy link
Copy Markdown

@jameshfisher jameshfisher commented Aug 12, 2022

Without this, I have to write something awful like:

import { EventWebhook } from '@sendgrid/eventwebhook';
let sendgridEcPublicKey: ReturnType<EventWebhook['convertPublicKeyToECDSA']>;

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

Without this, I have to write something awful like:

import { EventWebhook } from '@sendgrid/eventwebhook';
let sendgridEcPublicKey: ReturnType<EventWebhook['convertPublicKeyToECDSA']>;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant