fix(ci): stabilize nvm shell checks - #255
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74bf980706
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| CODEX_HOME: path.join(fakeNvmRoot, "codex-home"), | ||
| NVM_DIR: fakeNvmRoot, | ||
| SHELL: "/bin/sh", |
There was a problem hiding this comment.
/bin/sh from the developer profile
When a Unix developer's ~/.profile exposes a newer codex than the fixture's 9.9.9 binary, forcing SHELL to /bin/sh does not isolate this test: resolveLoginShellCommandPath invokes that shell with -ilc, so it loads the profile and discovers the real executable, and the resolver then selects the higher version, causing the codexPath assertions to fail. Give the probe a temporary HOME/PATH or mock login-shell discovery instead of only changing SHELL.
AGENTS.md reference: AGENTS.md:L13-L16
Useful? React with 👍 / 👎.
2 participants
Summary
terminal-runtime.tswithin the max-lines ratchet after the project NVM environment changeRoot cause
The merged project-NVM change pushed
terminal-runtime.tssix lines past its 1,170-line ratchet. Local CI-equivalent runs also exposed tests whose five-second timeout included cold provider-runtime imports, plus an NVM discovery fixture that invoked the user's real login-shell initialization.Verification
bun install --frozen-lockfilebun run check:reliability-gatesbun run check:max-lines-ratchetbun run check:switch-exhaustivenessbun run typecheckbun run test:isolated(300/300 files, Bun 1.3.12)