Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Fix async flush logic and flaky unit test#122

Merged
yzang2019 merged 5 commits into
mainfrom
yzang/fix-async-flush
Oct 9, 2025
Merged

Fix async flush logic and flaky unit test#122
yzang2019 merged 5 commits into
mainfrom
yzang/fix-async-flush

Fix for rocksdb

c88ff86
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 9, 2025 in 0s

40.68% (target 60.00%)

View this Pull Request on Codecov

40.68% (target 60.00%)

Details

Codecov Report

❌ Patch coverage is 66.66667% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.68%. Comparing base (c3ee918) to head (c88ff86).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
ss/store.go 11.76% 12 Missing and 3 partials ⚠️
ss/pebbledb/db.go 85.71% 2 Missing and 1 partial ⚠️

❌ Your project check has failed because the head coverage (40.68%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   40.00%   40.68%   +0.68%     
==========================================
  Files          59       59              
  Lines        7510     7534      +24     
==========================================
+ Hits         3004     3065      +61     
+ Misses       4161     4123      -38     
- Partials      345      346       +1     
Files with missing lines Coverage Δ
config/config.go 0.00% <ø> (ø)
ss/rocksdb/db.go 56.60% <100.00%> (+11.58%) ⬆️
ss/pebbledb/db.go 61.11% <85.71%> (+5.67%) ⬆️
ss/store.go 36.76% <11.76%> (-11.13%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.