feat(inprocess): Tier-2 subprocess harness — operational suites without docker#3709
Open
bdchatham wants to merge 1 commit into
Open
feat(inprocess): Tier-2 subprocess harness — operational suites without docker#3709bdchatham wants to merge 1 commit into
bdchatham wants to merge 1 commit into
Claude / Claude Code Review
completed
Jul 6, 2026 in 19m 45s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | inprocess/subprocess.go:528-537 |
Len/Nodes/Node docstrings claim 'validator' but include the statesync node |
Annotations
Check warning on line 537 in inprocess/subprocess.go
claude / Claude Code Review
Len/Nodes/Node docstrings claim 'validator' but include the statesync node
Docstrings for `Node(i)`, `Nodes()`, and `Len()` (subprocess.go:545-559) say "validator", but all three iterate `sn.net.nodes`, which `AddStatesyncNode` appends the non-validator `sei-rpc-node` to — so post-`AddStatesyncNode`, `Len()` returns validators+1 and the accessors can hand back the statesync node. The behavior is intentional (the runner's `nodeFor` resolves `sei-rpc-node` by iterating `Len()`, and `VoteYes` guards with `if n.moniker == statesyncNodeMoniker { continue }`) — just the doc
Loading