Skip to content

feat(sumcheck): enable frontload dependency set#1335

Open
hero78119 wants to merge 3 commits intomasterfrom
feat/frontload
Open

feat(sumcheck): enable frontload dependency set#1335
hero78119 wants to merge 3 commits intomasterfrom
feat/frontload

Conversation

@hero78119
Copy link
Copy Markdown
Collaborator

@hero78119 hero78119 commented May 6, 2026

Problem

Enable Ceno to consume the frontload sumcheck work from gkr-backend and ceno-gpu.

Design Rationale

This PR only updates dependency pins. The implementation lives in:

Area Summary
gkr_iop / gkr-backend Makes frontload/prefix sumcheck the default CPU path and keeps forced suffix available for comparison.
ceno-gpu Adds frontload support to GPU sumcheck v2 kernels, removes legacy v1 flat-buffer kernels, and keeps PCS/basefold on suffix.

Change Highlights

  • Update gkr-backend branch lock from the older frontload commit to the latest frontload dependency set.
  • Keep all Ceno gkr-backend crates on one consistent revision to avoid duplicate sumcheck / transcript types.

Benchmark / Performance Impact

Benchmark: Reth GPU E2E, block 23817600, CENO_GPU_ENABLE_WITGEN=0.
Positive percentage means faster.

Metric Baseline This PR Change
E2E total 75.400s 75.600s -0.3%
app_prove 60.400s 61.000s -1.0%
build_tower_witness_gpu 4.613s 3.491s +24.3%
prove_main_constraints 24.364s 22.622s +7.1%
pcs_opening 15.441s 15.246s +1.3%
prove_tower_relation_gpu 172.341s 176.090s -2.2%
GPU Span Baseline This PR Change
Tower prove_generic_sumcheck_gpu 161.604s 168.859s -4.5%
Main prove_generic_sumcheck_gpu 22.443s 21.244s +5.3%
PCS batch_commit_phase 6.566s 6.453s +1.7%
PCS batch_query_phase 4.615s 4.617s -0.0%

Raw results:

Testing

cargo install --git https://github.com/scroll-tech/ceno --branch feat/frontload --features jemalloc --features nightly-features --locked --force cargo-ceno
CENO_GPU_ENABLE_WITGEN=0 cargo run --features "jemalloc,gpu" --release --bin ceno-reth-benchmark-bin -- --mode prove-app --block-number 23817600

Risks and Rollout

Main risk is cross-repo dependency skew between ceno, gkr-backend, and ceno-gpu. Rollback is to revert the dependency update.

Follow-ups (optional)

Investigate tower GPU sumcheck regression while keeping PCS/basefold on suffix.

Copilot Reviewer Directive (keep this section)

When Copilot reviews this PR, apply .github/copilot-instructions.md strictly.

@hero78119 hero78119 changed the title Feat/frontload feat(sumcheck): enable frontload dependency set May 6, 2026
@hero78119 hero78119 requested a review from Copilot May 7, 2026 11:39
@hero78119
Copy link
Copy Markdown
Collaborator Author

@copilot update gkr-backend dependency to tag = "v1.0.0-alpha.26"

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Ceno’s gkr-backend dependency set to consume the latest “frontload/prefix” sumcheck work (CPU + GPU paths) while keeping all gkr-backend crates on a consistent revision to avoid duplicate types.

Findings (by severity):

  • Major (Cargo.toml:30-34): gkr-backend crates are now referenced via a moving branch instead of an immutable tag/rev, which reduces reproducibility/supply-chain safety for any build that doesn’t rely on this repo’s Cargo.lock (and makes accidental upgrades easier via cargo update). A concrete mitigation is to pin with rev = "<commit>" (or use a new immutable tag) for the whole gkr-backend set.

Open questions / assumptions:

  • Is the intent to track feat/frontload continuously, or to consume exactly commit f8847d88...? If the latter, switching to rev would better match the “dependency pin” goal stated in the PR description.

Changes:

  • Move gkr-backend workspace dependencies from v1.0.0-alpha.25 to the feat/frontload line.
  • Update Cargo.lock to the corresponding gkr-backend commit (f8847d88...) consistently across all affected crates.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
Cargo.toml Switch gkr-backend dependency references to feat/frontload.
Cargo.lock Update locked gkr-backend sources to the new commit for the frontload set.

Comment thread Cargo.toml Outdated
Agent-Logs-Url: https://github.com/scroll-tech/ceno/sessions/01709181-5d1b-4abe-ba47-ac7463cde01e

Co-authored-by: hero78119 <3962077+hero78119@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 7, 2026

@copilot update gkr-backend dependency to tag = "v1.0.0-alpha.26"

Updated all gkr-backend workspace deps to tag = "v1.0.0-alpha.26" and aligned Cargo.lock to the same tag commit in b19ea95.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/scroll-tech/gkr-backend/commits/feat/frontload
    • Triggering command: /home/REDACTED/.rustup/toolchains/nightly-2025-11-20-x86_64-REDACTED-linux-gnu/bin/cargo /home/REDACTED/.rustup/toolchains/nightly-2025-11-20-x86_64-REDACTED-linux-gnu/bin/cargo update -p sumcheck ewor�� lockfree_object_pool --edition=2021 /usr/bin/ld ibs -o tui_ui_sub tui_ui_sub.o libmpc-tests.la ../src/libmpc.la -lmpfr -lgmp -lm -lm (http block)
    • Triggering command: REDACTED, pid is -1 (http block)

If you need me to access, download, or install something from one of these locations, you can either:

@hero78119 hero78119 enabled auto-merge May 7, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants