feat(sumcheck): enable frontload dependency set#1335
feat(sumcheck): enable frontload dependency set#1335
Conversation
|
@copilot update gkr-backend dependency to tag = "v1.0.0-alpha.26" |
There was a problem hiding this comment.
Pull request overview
Updates Ceno’s gkr-backend dependency set to consume the latest “frontload/prefix” sumcheck work (CPU + GPU paths) while keeping all gkr-backend crates on a consistent revision to avoid duplicate types.
Findings (by severity):
- Major (Cargo.toml:30-34):
gkr-backendcrates are now referenced via a movingbranchinstead of an immutabletag/rev, which reduces reproducibility/supply-chain safety for any build that doesn’t rely on this repo’sCargo.lock(and makes accidental upgrades easier viacargo update). A concrete mitigation is to pin withrev = "<commit>"(or use a new immutable tag) for the wholegkr-backendset.
Open questions / assumptions:
- Is the intent to track
feat/frontloadcontinuously, or to consume exactly commitf8847d88...? If the latter, switching torevwould better match the “dependency pin” goal stated in the PR description.
Changes:
- Move
gkr-backendworkspace dependencies fromv1.0.0-alpha.25to thefeat/frontloadline. - Update
Cargo.lockto the correspondinggkr-backendcommit (f8847d88...) consistently across all affected crates.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Cargo.toml | Switch gkr-backend dependency references to feat/frontload. |
| Cargo.lock | Update locked gkr-backend sources to the new commit for the frontload set. |
Agent-Logs-Url: https://github.com/scroll-tech/ceno/sessions/01709181-5d1b-4abe-ba47-ac7463cde01e Co-authored-by: hero78119 <3962077+hero78119@users.noreply.github.com>
Updated all Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Problem
Enable Ceno to consume the frontload sumcheck work from
gkr-backendandceno-gpu.Design Rationale
This PR only updates dependency pins. The implementation lives in:
gkr_iop/gkr-backendceno-gpuChange Highlights
gkr-backendbranch lock from the older frontload commit to the latest frontload dependency set.gkr-backendcrates on one consistent revision to avoid duplicatesumcheck/transcripttypes.Benchmark / Performance Impact
Benchmark: Reth GPU E2E, block
23817600,CENO_GPU_ENABLE_WITGEN=0.Positive percentage means faster.
app_provebuild_tower_witness_gpuprove_main_constraintspcs_openingprove_tower_relation_gpuprove_generic_sumcheck_gpuprove_generic_sumcheck_gpubatch_commit_phasebatch_query_phaseRaw results:
Testing
cargo install --git https://github.com/scroll-tech/ceno --branch feat/frontload --features jemalloc --features nightly-features --locked --force cargo-ceno CENO_GPU_ENABLE_WITGEN=0 cargo run --features "jemalloc,gpu" --release --bin ceno-reth-benchmark-bin -- --mode prove-app --block-number 23817600Risks and Rollout
Main risk is cross-repo dependency skew between
ceno,gkr-backend, andceno-gpu. Rollback is to revert the dependency update.Follow-ups (optional)
Investigate tower GPU sumcheck regression while keeping PCS/basefold on suffix.
Copilot Reviewer Directive (keep this section)
When Copilot reviews this PR, apply
.github/copilot-instructions.mdstrictly.