Skip to content

Added the Downloads folder#841

Closed
chamiduu wants to merge 16 commits into
scorelab:developfrom
chamiduu:master
Closed

Added the Downloads folder#841
chamiduu wants to merge 16 commits into
scorelab:developfrom
chamiduu:master

Conversation

@chamiduu
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Collaborator

@kmehant kmehant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look through my comments.
And also reason behind again using a text file here .gitkeep.txt here

Comment thread .gitignore
!.vscode/extensions.json
.history

<<<<<<< HEAD
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix these conflicts

Comment thread .gitignore
!downloads/.gitkeep
=======
downloads/*
!downloads/.gitkeep
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the reason .gitkeep is used here
Can I use something like .downloads or something else?
Put forward your explanation.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct if I add these lines ?
#downloads .downloads

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That results In a comment due to #

Can you explain the reason .gitkeep is used here
Can I use something like .downloads or something else?

Hopefully you will answer this

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, I mean,
" #downlaods
.downloads

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That results In a comment due to #

Can you explain the reason .gitkeep is used here
Can I use something like .downloads or something else?

Hopefully you will answer this

I thought that code would not delete the downloads folder

@kmehant
Copy link
Copy Markdown
Collaborator

kmehant commented Dec 24, 2019

Squash your commits

@kmehant
Copy link
Copy Markdown
Collaborator

kmehant commented Dec 24, 2019

PR should be to develop branch not on master

@chamiduu chamiduu closed this Dec 24, 2019
@chamiduu chamiduu reopened this Dec 24, 2019
@JaDogg JaDogg self-requested a review December 24, 2019 08:55
Copy link
Copy Markdown
Collaborator

@JaDogg JaDogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't push conflicts. You need to merge those.

@chamiduu chamiduu changed the base branch from master to develop December 24, 2019 09:22
@kmehant kmehant closed this Dec 24, 2019
@kmehant
Copy link
Copy Markdown
Collaborator

kmehant commented Dec 24, 2019

#843 shifted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants