Repository navigation
fix(sdk): picker provider-guard fails soft by default, loud only behind strict=True - #89
Merged
Merged
Conversation
…nd strict=True (amended adoption rule 2026-10-24)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amended adoption rule (apps-crossapp-header-consistency-20261023, lead decision 2026-10-24): shared primitives must not crash provider-less hosts. The {% scitex_project_picker %} fail-fast from PR #80 broke the SAC release pipeline (v0.34.0/v0.35.0 red, ~76/77 from ImproperlyConfigured with no provider registered).
Change: provider-less project-scoped signed-in render returns empty slot by default; strict=True restores ImproperlyConfigured. Guard in creator views kept (now a markup optimization). Skill doc + comments updated. Tests: 2 fail-loud tests flipped to graceful, 2 strict tests added. Local: 816 passed (ui + selector alias + creator), lint/typecheck/vitest green.