ci(cla): add the push trigger scitex-io's caller has - #376
Open
ywatanabe1989 wants to merge 1 commit into
Open
Conversation
The reusable-workflow migration (PR #367) carried over the on: block's issue_comment/pull_request_target entries but dropped push, so the reusable's owner-bypass job (marks CLAssistant=success on a direct push by the allowlisted owner, since a push has no PR to sign against) never runs here. scitex-io's caller -- the file this migration was told to mirror -- triggers on push to [main, develop] plus v* tags; bring this repo's caller to parity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/cla.ymlalready delegates to the org reusableworkflow (
scitex-ai/.github/.github/workflows/cla.yml, merged viafix(cla): point the signature store at the renamed branch #367) but its
on:block dropped thepushtrigger that scitex-io'scaller (the file this migration was told to mirror) has. Without it
the reusable's
owner-bypassjob never fires on a direct push by theallowlisted owner.
push: { branches: [main, develop], tags: ['v*'] }, matchingscitex-io byte-for-byte on that block.
permissions:,default_branch(main),runs_on, and theowner_allowlist/secret mapping were already correct ondevelop(a prior session's fix(cla): point the signature store at the renamed branch #367 already did the reusable-workflow migration
properly, including SHA-pinning the callee and carrying over the
LLEmacsallowlist entry) — this PR only adds the missing trigger.IMPORTANT — this alone will NOT turn the live CLA check green
Verified empirically: GitHub resolves the workflow YAML for
pull_request_target(andissue_comment) from the repository'sdefault branch, not the PR's base branch — confirmed against
GitHub's own docs ("This event runs in the context of the default
branch of the base repository"). scitex-python's default branch is
main, andmainstill has the old, fully inlinecontributor-assistant/github-action@v2.6.1config pointing at thedeleted
cla-signaturesbranch.develophas had the correctreusable-workflow config since #367 merged (2026-08-30), yet every
CLA run since — on PRs based on develop, including this one — still
executes the old
mainconfig and fails with the sameBranch cla-signatures not founderror. Landing this ondevelopdoes not change that;
mainneeds the fix too (see PR #360,"promote develop → main", open since 2026-08-10).
Test plan
python3 -c "import yaml; yaml.safe_load(...)".