Improve exception handling in host matching task and avoid creating duplicate hosts#402
Draft
manning-ncsa wants to merge 30 commits intomainfrom
Draft
Improve exception handling in host matching task and avoid creating duplicate hosts#402manning-ncsa wants to merge 30 commits intomainfrom
manning-ncsa wants to merge 30 commits intomainfrom
Conversation
ec382cc to
21700f3
Compare
- avoid creating duplicate Host objects - populate new Host catalog info fields - handle errors more robustly
a471aaf to
09c8264
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #400
Fixes #403
Added
object_id,catalog_name,catalog_release) to capture thesource catalog information provided by the host matcher.
blast_adminDjango custommanagement command. See
blast_admin.pymodule docstring for details.Changed
HostMatch._run_process()function was altered to treat any unhandled exception as a failure with acorresponding "failed" status message. Previously, an unhandled exception would result in a misleading
"no host match" status.
Hostobjects: The hostinformation returned by Prost is compared against existing Host objects by cone search and by catalog information.
initialize_all_tasks_status()inreprocess_transient()Removed
from TNS are now triggered upon discovery. Thus, all pathways for adding new transients now automatically
initialize and trigger workflows immediately, eliminating the need for this periodic task.
Fixed