Skip to content

Add requirements.txt with legendarium dependency - #205

Open
robertatakenaka with Copilot wants to merge 4 commits into
masterfrom
copilot/add-requirements-txt-file
Open

Add requirements.txt with legendarium dependency#205
robertatakenaka with Copilot wants to merge 4 commits into
masterfrom
copilot/add-requirements-txt-file

Conversation

Copilot AI commented Apr 27, 2026

Copy link
Copy Markdown

O que esse PR faz?

Adiciona um requirements.txt declarando a dependência legendarium 2.0.6 a partir do arquivo no GitHub (já que o pacote não está publicado no PyPI) e atualiza o pin em setup.py para refletir a nova versão.

  • requirements.txt (novo): usa a sintaxe antiga (apenas a URL) para manter compatibilidade com Python 2.7 e versões antigas do pip:
    https://github.com/scieloorg/legendarium/archive/refs/tags/2.0.6.zip
    
  • setup.py: legendarium>=1.2.0legendarium>=2.0.6.

Onde a revisão poderia começar?

requirements.txt e setup.py.

Como este poderia ser testado manualmente?

Em um virtualenv limpo:

pip install -r requirements.txt
pip install .
python -c "from legendarium import formatter; from xylose import scielodocument"

Algum cenário de contexto que queira dar?

legendarium é a única dependência externa do pacote (importada em xylose/scielodocument.py) e não está disponível no PyPI, portanto precisa ser instalada via URL do arquivo do GitHub. O setup.py mantém um intervalo (>=) por se tratar de uma biblioteca, enquanto o requirements.txt fixa a versão exata para reprodutibilidade. A sintaxe antiga (URL diretamente, sem o prefixo PEP 508 legendarium @ ) é usada para manter compatibilidade com Python 2.7 / pip antigo.

Screenshots

N/A — alteração apenas de empacotamento.

Referências

Copilot AI and others added 2 commits April 27, 2026 18:08
Agent-Logs-Url: https://github.com/scieloorg/xylose/sessions/ea26b162-5b56-4957-90cd-2f10a1615446

Co-authored-by: robertatakenaka <505143+robertatakenaka@users.noreply.github.com>
Agent-Logs-Url: https://github.com/scieloorg/xylose/sessions/ea26b162-5b56-4957-90cd-2f10a1615446

Co-authored-by: robertatakenaka <505143+robertatakenaka@users.noreply.github.com>
Copilot AI changed the title [WIP] Add requirements.txt file with dependencies Add requirements.txt with legendarium dependency Apr 27, 2026
Copilot AI requested a review from robertatakenaka April 27, 2026 18:11
@robertatakenaka
robertatakenaka marked this pull request as ready for review April 27, 2026 19:07
Copilot AI review requested due to automatic review settings April 27, 2026 19:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project’s external dependency on legendarium to version 2.0.6, and introduces a requirements.txt entry that installs legendarium directly from a GitHub tag archive (since it’s not available via PyPI).

Changes:

  • Added requirements.txt pinning legendarium to the 2.0.6 GitHub tag archive via a PEP 508 direct reference.
  • Updated setup.py to require legendarium>=2.0.6.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
setup.py Bumps legendarium minimum required version to 2.0.6.
requirements.txt Adds a direct GitHub URL requirement for legendarium 2.0.6 for reproducible installs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread setup.py

requires = [
"legendarium>=1.2.0"
"legendarium>=2.0.6"
@robertatakenaka

Copy link
Copy Markdown
Member

@copilot isso tem que funcionar em python 2.7, então deve ser a sintaxe antiga https://github.com/scieloorg/legendarium/archive/refs/tags/2.0.6.zip

Copilot AI commented Apr 27, 2026

Copy link
Copy Markdown
Author

@copilot isso tem que funcionar em python 2.7, então deve ser a sintaxe antiga https://github.com/scieloorg/legendarium/archive/refs/tags/2.0.6.zip

Revertido para a sintaxe antiga (apenas a URL) em 15c835a para manter compatibilidade com Python 2.7 / pip antigo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crie o arquivo requirements.txt

3 participants