Repository navigation
Rebase the rebuilt paper.pdf before pushing - #365
Merged
Merged
Conversation
auto-bump-dev.yml can push to dev while the PDF builds, which rejected the plain push after the epic #324 merge. Checked with actionlint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Draft PDF run on the epic #324 merge commit (d79328b) failed.
Cause:
auto-bump-dev.ymlpushed the version bump todevwhile the PDF was building, so the plaingit pushof the rebuilt PDF was rejected as not up to date.Why it matters now: since Epic #324: first-class MLX and reference-faithful fitting #364, the PDF is committed back only on
devandmain, which makes that race the common case after a merge.Fix: the commit step now rebases onto the branch head before pushing, and retries up to three times. The bump never touches
paper.pdf, so the rebase cannot conflict.actionlintcleanAfter this merges, a manual run of the workflow on
devrebuilds the PDF for the merged paper.