Repository navigation
Drop obsolete seed patch from Fortran build - #295
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weekly macOS slow job's first calibration run failed (auto-filed #294): benchmarks/fortran/build_amica.sh still applied a pre-#235 sed patch replacing the old ifort-only size-2 random_seed(PUT=...) line, whose anchor check now fails because #235 rewrote the seeding to the portable form (random_seed(size=nseed) + allocated seedvec, sccn/amica PR #54). The patch is not just mis-anchored but harmful: if it matched, it would replace #235's deterministic seed-param behavior with a clock seed.
Fix: remove the sed patch entirely and replace the guard with an anchor check for the post-#235 portable seeding line, so future source drift still fails loudly at build time rather than at runtime. Verified locally: the build compiles clean through mpif90 on Apple Silicon with the fix.
Closes #294.