fix(icon): stabilize fallback rendering (mount flash, layout shift, spinner)#1122
Open
JeanMarcMilletScality wants to merge 5 commits into
Open
fix(icon): stabilize fallback rendering (mount flash, layout shift, spinner)#1122JeanMarcMilletScality wants to merge 5 commits into
JeanMarcMilletScality wants to merge 5 commits into
Conversation
Contributor
Hello jeanmarcmilletscality,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
f28d9d7 to
e063c8f
Compare
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…nstant Addresses review feedback: - When `name` changes on a mounted Icon to an icon that isn't cached yet, reset `icon` to undefined so the reserved fallback shows instead of the previous glyph while the dynamic import resolves. - Extract the fallback spinner color into a named LOADER_SPINNER_COLOR constant (mirrors the <Loader> default) instead of an inline magic hex. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
bfd6732 to
e270b79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #1120, which mixed unrelated table, icon, and storybook changes. This PR contains only the Icon work.
Changes
sizeinstead of a fixed px valueFiles
src/lib/components/icon/Icon.component.tsxstories/icon.stories.tsxVerification
npm run build-storybookcompletes successfully (exit 0).🤖 Generated with Claude Code