Upgrade microVersionId to timestamp-ordered format and add isReplica by maeldonn · Pull Request #2628 · scality/Arsenal

maeldonn · 2026-05-22T14:11:04Z

Replace the random 8-byte hex microVersionId with a 20-character timestamp-ordered identifier matching the versionId scheme, and add encode/decode/compare helpers in a new MicroVersionID module. Add an optional isReplica flag to ReplicationInfo to distinguish replica writes from user writes, enabling cascaded CRR.

Issue: ARSN-578

Crr cascaded design : https://github.com/scality/citadel/pull/349
Related PRs :
Cloudserver : scality/cloudserver#6179
CloudserverClient : scality/cloudserverclient#24
Backbeat : Not done yet
S3utils : scality/s3utils#395

bert-e · 2026-05-22T14:11:09Z

Hello maeldonn,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2026-05-22T14:11:14Z

Incorrect fix version

The Fix Version/s in issue ARSN-578 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

8.4.3

Please check the Fix Version/s of ARSN-578, or the target
branch of this pull request.

claude · 2026-05-22T14:13:46Z

LGTM

Review by Claude Code

claude · 2026-05-22T14:58:02Z

Breaking API change: updateMicroVersionId() now requires a replicationGroupId argument, which will break all existing callers in downstream repos (CloudServer, Backbeat, etc.). Coordinate updates or consider an optional parameter with a fallback.
- Make the parameter optional with a random default, or ensure all consumers are updated in the same release cycle.
updateMicroVersionId JSDoc says @return itself but the method body has no return this statement.
- Add return this; for consistency with other ObjectMD setters.

Review by Claude Code

claude · 2026-05-22T15:26:01Z

LGTM

The changes are well-structured: the new MicroVersionId module correctly mirrors the VersionId timestamp-ordering scheme with its own isolated sequencing state, the isReplica flag is cleanly additive and backward compatible, and the test coverage is thorough (uniqueness, ordering, encode/decode round-trip, compare, padding/truncation).

Review by Claude Code

bert-e · 2026-05-22T18:03:11Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

claude · 2026-05-22T18:23:17Z

updateMicroVersionId JSDoc says @return itself but the method doesn't return this, breaking the chaining convention used by all other setters in ObjectMD. Since the method is being rewritten, add return this;.

Review by Claude Code

claude · 2026-05-22T18:28:25Z

     */
-    updateMicroVersionId() {
-        this._data.microVersionId = crypto.randomBytes(8).toString('hex');
+    updateMicroVersionId(replicationGroupId: string) {


Breaking API change: updateMicroVersionId() now requires a replicationGroupId argument. All downstream callers (CloudServer, Backbeat, etc.) that invoke this method without arguments will fail at compile time. Ensure coordinated updates across dependent repos.

— Claude Code

claude · 2026-05-22T18:28:34Z

LGTM — one breaking change to flag:

- updateMicroVersionId() signature changed to require a replicationGroupId parameter — downstream callers (CloudServer, Backbeat) must be updated in lockstep

The new MicroVersionId module, isReplica field, and timestamp-ordered format all look correct. Backward compatibility for existing stored metadata (old 16-char random hex microVersionIds) is preserved since getMicroVersionId() returns the raw value and _updateFromParsedJSON copies it as-is.

Review by Claude Code

claude · 2026-05-27T07:50:20Z

updateMicroVersionId JSDoc says @return itself but the method returns void — add return this; or remove the tag
- See inline comment with suggestion

Review by Claude Code

francoisferrand · 2026-05-28T12:44:50Z

-    updateMicroVersionId() {
-        this._data.microVersionId = crypto.randomBytes(8).toString('hex');
+    updateMicroVersionId(instanceId: string, replicationGroupId: string) {
+        this._data.microVersionId = VersionIDUtils.generateVersionId(instanceId, replicationGroupId);


are the instanceID and replicaitionGroupId not usually pick'ed up (in arsenal!) by env variables?
(i.e. do we need to have params, or can we just pick the right values automatically)

For instance id, we have this in cloudserver so maybe we could :

const instanceId = process.env.CLOUDSERVER_INSTANCE_ID || config.instanceId;

But for replicationGroupId, it's not an env variable.

And this function will also be used by S3UTILS so I think we have to leave it like this

SylvainSenechal · 2026-05-29T16:29:09Z

+     * Get whether this object was written by replication (replica).
+     * @return true if this object is a replica
+     */
+    getReplicationIsReplica() {


i think we should still also have an || data.replicationInfo.status === 'REPLICA' for cross compatiblity with older code ?

bert-e · 2026-06-01T08:38:35Z

Conflict

There is a conflict between your branch improvement/ARSN-578/micro-version-id and the
destination branch development/8.4.

Please resolve the conflict on the feature branch (improvement/ARSN-578/micro-version-id).

git fetch && \
git checkout origin/improvement/ARSN-578/micro-version-id && \
git merge origin/development/8.4

Resolve merge conflicts and commit

git push origin HEAD:improvement/ARSN-578/micro-version-id

SylvainSenechal · 2026-06-01T08:53:06Z

+     * Get whether this object was written by replication (replica).
+     * @return true if this object is a replica
+     */
+    getReplicationIsReplica() {


call it "isReplica" ? and the setter "setReplica" ?

SylvainSenechal · 2026-06-01T08:53:33Z

+     * @param isReplica - true if this object was written by replication
+     * @return itself
+     */
+    setReplicationIsReplica(isReplica: boolean) {


wonder if we should also set
replicationInfo.status = 'REPLICA'

SylvainSenechal · 2026-06-01T11:39:40Z

            storageType: storageType || '',
            dataStoreVersionId: dataStoreVersionId || '',
            isNFS,
+            isReplica: isReplica !== undefined ? isReplica : (status === 'REPLICA' ? true : undefined),


Suggested change

isReplica: isReplica !== undefined ? isReplica : (status === 'REPLICA' ? true : undefined),

isReplica: isReplica !== undefined ? isReplica : (status === 'REPLICA' ? true : false),

not sure if undefined or false when status not REPLICA

bert-e · 2026-06-02T17:58:12Z

Incorrect fix version

The Fix Version/s in issue ARSN-578 contains:

8.4.4

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

8.4.5

Please check the Fix Version/s of ARSN-578, or the target
branch of this pull request.

claude · 2026-06-02T18:00:33Z

     */
    getMicroVersionId() {
-        return this._data.microVersionId || null;
+        return this._data.microVersionId || undefined;


Return value changed from null to undefined. Any downstream caller in CloudServer/Backbeat checking getMicroVersionId() === null will silently stop matching. If this is intentional, it should be called out in the PR description as a breaking change so dependent repos can audit their checks.

— Claude Code

no worries this function wasn't even called before https://github.com/search?q=org%3Ascality%20getMicroVersionId&type=code

i switched to undefined to align with getEncodedVersionId, and because it fits better the client that can use string | undefined

claude · 2026-06-02T18:00:47Z

+    incomingRaw: string,
+    existingRaw: string | null | undefined,
+): 'loop' | 'stale' | 'proceed' {
+    if (!isMicroVersionIdComparable(existingRaw)) {


checkCrrCascadeEvent validates existingRaw with isMicroVersionIdComparable but does not validate incomingRaw. If incomingRaw is a legacy 16-char random-hex microVersionId, the lexicographic comparison against a time-ordered ID is meaningless and can return incorrect results (e.g. a hex value starting with f will sort after the time-ordered value, producing a false stale). Add !isMicroVersionIdComparable(incomingRaw) to the guard clause.

— Claude Code

claude · 2026-06-02T18:00:56Z

checkCrrCascadeEvent does not validate incomingRaw with isMicroVersionIdComparable, so comparing a legacy 16-char hex microVersionId against a time-ordered ID can produce incorrect stale/proceed results.
- Add !isMicroVersionIdComparable(incomingRaw) to the guard clause at line 393 of VersionID.ts.
- getMicroVersionId() return value changed from null to undefined — a silent breaking change for downstream callers checking === null.
- Document this as a breaking change, or keep returning null for backward compatibility.
- No tests for isMicroVersionIdComparable and checkCrrCascadeEvent — these new exported functions have four code paths that need coverage.
- Add unit tests covering non-comparable input, loop, stale, and proceed cases.

Review by Claude Code

codecov · 2026-06-02T18:06:14Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.71%. Comparing base (a1fa5b4) to head (2c429ab).

Additional details and impacted files

@@                 Coverage Diff                 @@
##           development/8.4    #2628      +/-   ##
===================================================
+ Coverage            73.65%   73.71%   +0.06%     
===================================================
  Files                  223      223              
  Lines                18247    18268      +21     
  Branches              3776     3807      +31     
===================================================
+ Hits                 13440    13467      +27     
+ Misses                4802     4796       -6     
  Partials                 5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Replace the random 8-byte hex microVersionId the timestamp-ordered identifier matching the versionId scheme, and add helpers for the crr cascade feature. Add an optional isReplica flag to ReplicationInfo to distinguish replica writes from user writes, enabling cascaded CRR. Issue: ARSN-578

Issue: ARSN-578

claude · 2026-06-02T19:27:25Z

getMicroVersionId() return value changed from null to undefined when unset — this is a silent breaking change for any caller using === null
- Either keep returning null for backward compatibility, or confirm all downstream callers (CloudServer, Backbeat, S3utils) have been updated to handle undefined

- updateMicroVersionId() signature changed from zero args to two required args (instanceId, replicationGroupId) — coordinated breaking change
- PR body notes Backbeat and S3utils PRs are "Not done yet"; ensure those are updated before merging this

Review by Claude Code

maeldonn requested review from a team, SylvainSenechal and benzekrimaha May 22, 2026 14:11