fix: benchmark Flare loading and broken SmolLM2 GGUF URLs#308
fix: benchmark Flare loading and broken SmolLM2 GGUF URLs#308sauravpanda merged 1 commit intomainfrom
Conversation
- Fix Flare WASM parse error: @sauravpanda/flare@0.2.0 has a nested block comment "/* done */" inside a JSDoc block that prematurely closes the /** */ comment. Benchmark now patches this before import. - Fix Transformers.js 0 tok/s: it runs batch (non-streaming), so tok/s is now calculated as tokens/totalTime instead of tokens/decodeTime. - Fix SmolLM2 GGUF URLs: HuggingFaceTB repo returns 401, switched to bartowski's public repos for 135M (Q8_0, Q4_K_M) and 360M (Q8_0). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated Flare model registry URLs to point to the Changes
Sequence Diagram(s)sequenceDiagram
participant Browser
participant CDN
participant Blob as Blob URL
participant WASM as Flare WASM
Browser->>CDN: Fetch flare_web.js
CDN-->>Browser: Return JS source
Browser->>Browser: Patch import.meta.url<br/>& remove comments
Browser->>Blob: Create blob URL<br/>from patched source
Blob-->>Browser: Return blob URL
Browser->>Browser: Import patched module<br/>via blob URL
Browser->>WASM: Initialize with wasmUrl
WASM-->>Browser: Module ready
Browser->>Browser: Revoke blob URL
alt Error during blob import
Browser->>CDN: Fallback: fetch<br/>from CDN directly
CDN-->>Browser: Return module
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
@sauravpanda/flare@0.2.0has a wasm-pack codegen bug where/* done */inside a JSDoc block prematurely closes the/** */comment, causing "Unexpected token '*'". Benchmark now patches the source before blob-importing.tokens/totalTime.Test plan
npm run buildclean🤖 Generated with Claude Code
Summary by CodeRabbit