Skip to content

rating: run integration conformance against the REAL migration DDL #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hhuuggoo merged 1 commit into from
Jun 17, 2026
Merged

rating: run integration conformance against the REAL migration DDL #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 46 additions & 16 deletions internal/rating/store_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,40 @@ import (
_ "github.com/jackc/pgx/v5/stdlib"
)

// schemaDDL is the rating schema (just billing_event + rated_usage now — prices are
// a YAML file, not DB tables), created in an isolated schema per test run so the
// test is self-contained and leaves no residue.
const schemaDDL = `
// ratingSchemaDDL returns the rating schema applied before each integration test
// (billing_event + rated_usage — prices are a YAML file, not DB tables). It is
// loaded from the REAL migration .sql files rather than a hand-copied constant, so
// the conformance test runs against EXACTLY the production schema and can never
// silently drift from it: a column-type or index-expression change in the
// migration that the test didn't track would otherwise pass green here and break
// in prod. Loading 0001 then 0002_rating reproduces the production apply order;
// base_model is declared in 0001 and re-added IF NOT EXISTS in 0002_rating, so the
// overlap is a harmless no-op. The DDL runs inside the per-test isolated schema
// (search_path is set by the caller), leaving no residue. io_log (0002_io_log) is
// intentionally not loaded — the rater never touches it.
func ratingSchemaDDL(t *testing.T) string {
t.Helper()
var b strings.Builder
for _, f := range []string{
"../../migrations/0001_billing_event.sql",
"../../migrations/0002_rating.sql",
} {
ddl, err := os.ReadFile(f)
if err != nil {
t.Fatalf("read migration %s: %v (the integration test applies the REAL "+
"migration DDL so it can't drift from production)", f, err)
}
b.Write(ddl)
b.WriteString("\n")
}
return b.String()
}

// schemaDDLReference is the previously hand-maintained schema, kept ONLY as a
// readable in-file description of what the loaded migrations produce. It is NOT
// applied (ratingSchemaDDL loads the real files); if you edit it, you are editing
// a comment. Drift between this and the migrations is now harmless.
const schemaDDLReference = `
-- billing_event mirrors the v1 metering schema (migration 0001): the model NAME
-- lives in the model column, which the rater aliases to model_id (the price key).
CREATE TABLE billing_event (
Expand Down Expand Up @@ -104,7 +134,7 @@ func TestIntegration_RateWindow_ConformsToOracle(t *testing.T) {
exec(t, db, "CREATE SCHEMA "+sch)
exec(t, db, "SET search_path TO "+sch)
defer func() { exec(t, db, "DROP SCHEMA IF EXISTS "+sch+" CASCADE") }()
exec(t, db, schemaDDL)
exec(t, db, ratingSchemaDDL(t))

hour := mustTime("2026-06-08T10:00:00Z")
book := conformanceBook()
Expand Down Expand Up @@ -244,7 +274,7 @@ func TestIntegration_ResourceIDGrainAndFailClosed(t *testing.T) {
exec(t, db, "CREATE SCHEMA "+sch)
exec(t, db, "SET search_path TO "+sch)
defer func() { exec(t, db, "DROP SCHEMA IF EXISTS "+sch+" CASCADE") }()
exec(t, db, schemaDDL)
exec(t, db, ratingSchemaDDL(t))

hour := mustTime("2026-06-08T10:00:00Z")
book := newTestBook(
Expand Down Expand Up @@ -356,7 +386,7 @@ func TestConformance_PremiumQuantizedBeforeBilling(t *testing.T) {
exec(t, db, "CREATE SCHEMA "+sch)
exec(t, db, "SET search_path TO "+sch)
defer func() { exec(t, db, "DROP SCHEMA IF EXISTS "+sch+" CASCADE") }()
exec(t, db, schemaDDL)
exec(t, db, ratingSchemaDDL(t))

hour := mustTime("2026-06-08T10:00:00Z")

Expand Down Expand Up @@ -449,7 +479,7 @@ func TestConformance_OracleQuantizesBeforeMultiply_OnResidue(t *testing.T) {
exec(t, db, "CREATE SCHEMA "+sch)
exec(t, db, "SET search_path TO "+sch)
defer func() { exec(t, db, "DROP SCHEMA IF EXISTS "+sch+" CASCADE") }()
exec(t, db, schemaDDL)
exec(t, db, ratingSchemaDDL(t))

hour := mustTime("2026-06-08T10:00:00Z")
book := newTestBook(
Expand Down Expand Up @@ -541,7 +571,7 @@ func TestIntegration_FineTunePricesViaBaseModel(t *testing.T) {
exec(t, db, "CREATE SCHEMA "+sch)
exec(t, db, "SET search_path TO "+sch)
defer func() { exec(t, db, "DROP SCHEMA IF EXISTS "+sch+" CASCADE") }()
exec(t, db, schemaDDL)
exec(t, db, ratingSchemaDDL(t))

hour := mustTime("2026-06-08T10:00:00Z")
// File declares ONLY the base; the ft: checkpoint id is not listed. 1.5× premium.
Expand Down Expand Up @@ -635,7 +665,7 @@ func TestIntegration_FineTuneAmbiguousBaseModelFailsLoud(t *testing.T) {
exec(t, db, "CREATE SCHEMA "+sch)
exec(t, db, "SET search_path TO "+sch)
defer func() { exec(t, db, "DROP SCHEMA IF EXISTS "+sch+" CASCADE") }()
exec(t, db, schemaDDL)
exec(t, db, ratingSchemaDDL(t))

hour := mustTime("2026-06-08T10:00:00Z")
book := newTestBook(
Expand Down Expand Up @@ -723,7 +753,7 @@ func TestIntegration_ReRateReconciles(t *testing.T) {
exec(t, db, "CREATE SCHEMA "+sch)
exec(t, db, "SET search_path TO "+sch)
defer func() { exec(t, db, "DROP SCHEMA IF EXISTS "+sch+" CASCADE") }()
exec(t, db, schemaDDL)
exec(t, db, ratingSchemaDDL(t))

hour := mustTime("2026-06-08T10:00:00Z")
book := newTestBook(
Expand Down Expand Up @@ -823,7 +853,7 @@ func TestIntegration_ReRateReconcileLeavesOtherWindowsUntouched(t *testing.T) {
exec(t, db, "CREATE SCHEMA "+sch)
exec(t, db, "SET search_path TO "+sch)
defer func() { exec(t, db, "DROP SCHEMA IF EXISTS "+sch+" CASCADE") }()
exec(t, db, schemaDDL)
exec(t, db, ratingSchemaDDL(t))

hour10 := mustTime("2026-06-08T10:00:00Z")
hour12 := mustTime("2026-06-08T12:00:00Z")
Expand Down Expand Up @@ -897,7 +927,7 @@ func TestIntegration_OneHopFineTuneCannotDeriveFromFineTune(t *testing.T) {
exec(t, db, "CREATE SCHEMA "+sch)
exec(t, db, "SET search_path TO "+sch)
defer func() { exec(t, db, "DROP SCHEMA IF EXISTS "+sch+" CASCADE") }()
exec(t, db, schemaDDL)
exec(t, db, ratingSchemaDDL(t))

hour := mustTime("2026-06-08T10:00:00Z")
// A true base AND an own-rate fine-tune (ft:ownrate) priced directly in the file.
Expand Down Expand Up @@ -968,7 +998,7 @@ func TestIntegration_UTCBucketing_SessionTZIndependent(t *testing.T) {
exec(t, db, "CREATE SCHEMA "+sch)
exec(t, db, "SET search_path TO "+sch)
defer func() { exec(t, db, "DROP SCHEMA IF EXISTS "+sch+" CASCADE") }()
exec(t, db, schemaDDL)
exec(t, db, ratingSchemaDDL(t))

hour := mustTime("2026-06-08T10:00:00Z")
book := newTestBook(
Expand Down Expand Up @@ -1038,7 +1068,7 @@ func TestIntegration_RatingInstantIndexServesScan(t *testing.T) {
exec(t, db, "CREATE SCHEMA "+sch)
exec(t, db, "SET search_path TO "+sch)
defer func() { exec(t, db, "DROP SCHEMA IF EXISTS "+sch+" CASCADE") }()
exec(t, db, schemaDDL)
exec(t, db, ratingSchemaDDL(t))

exec(t, db, "SET enable_seqscan = off")
plan := explainPlan(t, db, `EXPLAIN SELECT * FROM billing_event
Expand Down Expand Up @@ -1087,7 +1117,7 @@ func TestIntegration_ReconcileDeleteCanUseWindowStartIndex(t *testing.T) {
exec(t, db, "CREATE SCHEMA "+sch)
exec(t, db, "SET search_path TO "+sch)
defer func() { exec(t, db, "DROP SCHEMA IF EXISTS "+sch+" CASCADE") }()
exec(t, db, schemaDDL)
exec(t, db, ratingSchemaDDL(t))

// POPULATE a small, ANALYZE'd population: 10 distinct auth_ids × 24 hours = 240
// rated_usage rows across a couple dozen windows. That is enough for the
Expand Down
Loading