Repository navigation
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4 #438 +/- ##
=====================================
Coverage ? 92.53%
=====================================
Files ? 2
Lines ? 1072
Branches ? 132
=====================================
Hits ? 992
Misses ? 80
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
PerryLink
added a commit
to PerryLink/satori
that referenced
this pull request
Oct 29, 2026
Same one-line script change as satorijs#438. It is only here so this branch can run its own tests before satorijs#438 lands; drop it when rebasing on v4 after satorijs#438 is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
testrunsyakumo test --import tsx, but the loader never reaches thenode --testchild process.yakumo's CLI splices every--import <path>argument out ofprocess.argvand imports it into its own process; thetestcommand then spawnsnode --testwith only the options that are still present. The child therefore gets no TypeScript loader and dies on the first.tsfile:This is exactly the failure visible on the current
v4head in CI:test (20)andtest (22)both end withERR_UNKNOWN_FILE_EXTENSIONbefore any test runs.Fix
Put the loader in
NODE_OPTIONS, which the spawnednode --testinherits:One line. POSIX shell syntax is fine here — CI runs on
ubuntu-latest, and the existing scripts already rely on a POSIX shell.Relation to #433
#433carries the same change againstmain.mainis no longer where development happens: its install has been broken since 2026-10-07 on an unpublished dependency, and active work moved tov4. This PR is thev4version of that fix;#433is superseded by it.Verification (local, Node 24.22.1)
Before, with the old script:
After:
Also:
pnpm exec yakumo build element— exit 0 (lib/index.cjs,lib/index.mjs,lib/index.d.tsemitted)pnpm lint— exit 0 (no output)CI
On
v4's head thetestjob was red for this reason — it died at load time, not on an assertion (run 40496672330). With this PR all relevant checks pass (40895466269):test (20)— successtest (22)— success (13 tests, 13 pass, 0 fail;@satorijs/elementand@satorijs/protocolboth load)lint— successbuild— successpublish— skipped on pull requestsFor completeness: the
publishjob is red on thev4head run, but that is a pre-existing failure unrelated to this one-line script change. Thetestjob's red state was not an unrelated pre-existing assertion failure — it was this loader bug, and it is fixed here.