Repository navigation
Conversation
`yarn lint` exits 1 on main with 30 errors: - 25 x `@typescript-eslint/no-unused-vars` for a `Context` import that no longer has a use. They were left behind by fc61aa1 ("refa: remove context generics") and the refactors around it, which dropped the `Context` type argument from the encoder and client classes. - 4 x `padded-blocks` and 1 x `lines-between-class-members` in the kook and slack http servers. The failure has been masked because Install fails first, so the Lint step is skipped. Remove the dead imports and the stray blank lines. No behaviour changes.
Contributor
Author
|
Closing this: it cannot get past the install step on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yarn lintexits 1 onmainwith 30 errors, and thelintjob never shows it:Installfails first, soLintis skipped. This removes the dead code so the job can go green.What it fixes
On
mainatdb22bb3c:The 30 errors are three groups:
@typescript-eslint/no-unused-vars'Context' is defined but never usedpadded-blocksadapters/kook/src/http.ts,adapters/slack/src/http.tslines-between-class-membersadapters/slack/src/ws.tsThe unused
Contextimports are leftovers fromfc61aa1("refa: remove context generics") and the refactors around it: those commits dropped theContexttype argument from the encoder and client classes and left the import behind. The rule iserrorin.eslintrc.yml.Why it has been invisible
The
lintjob's steps on the currentmaintip (run 37651177817):Enable Corepacksuccess,Installfailure,Lintskipped.Installdies on@cordisjs/url-is-local@^1.0.0, which is not on npm, soLinthas not run for months. Once install works again,Lintwill run, and this is what it will report.This is a regression, not unenforced style. The job was green until
5f2b43ae(2026-04-12) and red fromfc61aa1b(2026-04-13) on, the commit that removed the context generics. Install still worked until 04-21, soLintreally did run and really did fail on those runs.Left alone
The 6 remaining warnings: 5 x
sort-importsand 1 xmax-len. ESLint exits 0 with warnings only, and the script has no--max-warnings, so they do not affect the job.--fixalso movesas-aliased specifiers to the front of the list (text as $textahead ofat), which reads worse. No lint rule or config was changed.Verification
Cold, with
.eslintcachedeleted first, since CI never has one:yarn buildis already red here for unrelated reasons, so I compared tsc error sets rather than counts, after deleting every*.tsbuildinfoand every emittedlib/— a warm build hides TS errors:Diffing on file, line, column, code and message: 0 new, 0 removed. Three TS2724 diagnostics shift up one line because the import line above them was deleted; they are otherwise identical.
Every changed line is either an
import { ... } from '@satorijs/core'line or a blank line, checked over the whole diff (+22/-29).The two files that also carry
declare module '@satorijs/core'(adapters/line/src/index.ts,adapters/telegram/src/index.ts) keep a working augmentation:Session['line']andSession['telegram']still resolve, next to a bogus property as a live negative control, which does error.corepack yarn testexits 0 with# tests 0, # suites 2. The suite has noit()blocks, so it is unchanged either way.