Add support for Generic NRF52805 by nikolac · Pull Request #442 · sandeepmistry/arduino-nRF5

nikolac · 2020-12-19T21:26:21Z

I made a couple of questionable decisions:

I'm not 100% sure how to determine maximum upload size. I set 192000.
This chip does not support PWM, so in addition to making all of the internal PWM references conditional based PWM_PRESENT, I also wrapped the contents of analogWrite with the condition. Would it be more appropriate to make the analogWrite definition conditional? Probably better to throw compiler errors if somebody tried to use it?

sandeepmistry

@nikolac great work!

I do not have an nRF52085 based device board to try these changes out with. However, I made a few inline comments.

sandeepmistry · 2021-01-02T14:57:58Z

boards.txt

+
+Generic_nRF52805.upload.tool=sandeepmistry:openocd
+Generic_nRF52805.upload.target=nrf52
+Generic_nRF52805.upload.maximum_size=192000


Based on https://github.com/sandeepmistry/arduino-nRF5/blob/master/cores/nRF5/SDK/components/toolchain/gcc/nrf52805_xxaa.ld

should this be:

0x30000 = 196608

?

Fixed here a60f6db

sandeepmistry · 2021-01-02T14:58:55Z

libraries/SPI/SPI.cpp


 #if SPI_INTERFACES_COUNT > 0
-#if defined(NRF52_SERIES)
+#if defined(NRF52_SERIES) && !defined(NRF52805_XXAA)


Maybe this could be #if defined(NRF_SPI2)?

+1 That would make it work on nrf52810 as well.

Done here 1109102

sandeepmistry · 2021-01-02T15:01:42Z

libraries/Wire/Wire_nRF52.cpp

 }

-TwoWire Wire(NRF_TWIM1, NRF_TWIS1, SPIM1_SPIS1_TWIM1_TWIS1_SPI1_TWI1_IRQn, PIN_WIRE_SDA, PIN_WIRE_SCL);
+#if defined(NRF52805_XXAA)


Could also consider #if defined(NRF_TWIM1 here as well.

I believe the NRF52805 has completely different handler names (TWIM0_TWIS0_TWI0_IRQn vs SPIM0_SPIS0_TWIM0_TWIS0_SPI0_TWI0_IRQn) which was part of the reason for using the board specific logic.

Got it, sorry for not checking this out before!

sureshsitaula · 2021-01-03T23:29:48Z

cores/nRF5/Uart.cpp


 void Uart::begin(unsigned long baudrate, uint16_t /*config*/)
 {
+#ifdef NRF52805_XXAA


Edit the macros in the compat header instead?
This is what I did here: edited cores/nRF5/SDK/components/device/nrf52_to_nrf52810.h and I didn't need to modify this file.

(See existing implementation for some other chips, see nrf52840 for example).

Should we be touching code in the SDK? Does that introduce potential upgrade complexity?

Good question for @sandeepmistry :)
It would be nice to have this consistency between compat .h files, like nrf52_to_nrf52840.h referenced above.

Should we be touching code in the SDK? Does that introduce potential upgrade complexity?

It would be better to avoid doing this, as it would be one more thing to manage when updating the SDK.

That said if it's the best approach wrapping changes in #ifdef ARDUINO would be best.

Am I good to leave this as-is for now? There is already series and, in some special cases, chip specific logic in the .cpp library files. I would prefer to leave this condition where it is until we decide on the best way/place to extend SDK definitions without modifying the SDK.

However, I'll do whatever you feel is best. There is increased interest to get this merged in, so whatever I can do to help expedite.

nikolac · 2022-09-06T14:56:05Z

Just wanted to follow up on this. I've been using this branch for ~2 years.

tobigun · 2024-03-11T23:27:51Z

What is the status of this pull-request?
I have solved the conflicts in my branch and also implemented analogWrite() the same way it was done in nRF51:
https://github.com/tobigun/arduino-nRF5/tree/support-nrf52805

spike314 · 2025-04-18T19:50:03Z

Thanks for this fork nikolac. I know this PR is a bit stale, but it was very helpful. I was frustrated using the NRF52810 because I could not get the I2C to work. Turns out if follows the same pattern as the NRF52805, so I was able to use your updates. Now have NRF52805 and NRF52810 nodes working.

nikolac added 3 commits December 18, 2020 16:07

Fix UART references for 52805

ab5b6ae

Add condition for SPI NRF52805

8dd6eca

Add condition for I2C NRF52805

980f0dc

This was referenced Dec 19, 2020

Is nRF52805 supported? If not, how can I help? #441

Closed

Add nrf52805 support mysensors/MySensors#1461

Merged

Add nrf52805 support mysensors/ArduinoHwNRF5#12

Open

sandeepmistry reviewed Jan 2, 2021

View reviewed changes

sureshsitaula reviewed Jan 3, 2021

View reviewed changes

nikolac added 2 commits January 5, 2021 10:42

Set appropriate max upload size

a60f6db

Init SPI2 if defined

1109102

valeros mentioned this pull request Feb 24, 2021

No FPU unit in NRF52810 and NRF52805 platformio/builder-framework-arduino-nrf5#10

Open

DirtyEngineer mentioned this pull request Apr 5, 2021

Adding a S112/S113 SoftDevice to Core #456

Open

Uh oh!

Conversation

nikolac commented Dec 19, 2020

Uh oh!

sandeepmistry left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sureshsitaula Jan 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikolac Mar 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikolac commented Sep 6, 2022

Uh oh!

tobigun commented Mar 11, 2024

Uh oh!

spike314 commented Apr 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sureshsitaula Jan 3, 2021 •

edited

Loading

nikolac Mar 18, 2021 •

edited

Loading