Propagate sigint_timeout/sigkill_timeout to the final process.stop() on exit#383
Open
cycsmail wants to merge 1 commit into
Open
Propagate sigint_timeout/sigkill_timeout to the final process.stop() on exit#383cycsmail wants to merge 1 commit into
cycsmail wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_process()forwardssigint_timeout/sigkill_timeouttoprocess.stop()on each reload, but the final stop in thefinallyblock was called with no arguments, so on exit/Ctrl+C it fell back to the default 5s/1s timeouts and ignored the values you passed in. This forwards the kwargs to that final stop too. Added a test that spies onCombinedProcess.stopand asserts both the in-loop and final stops use the custom timeouts (fails without the change, passes with it). Leftarun_processalone since #258 is about syncrun_processand it doesn't expose these params. run_process/cli tests pass locally (47 passed, 1 skipped), ruff clean.Fixes #258